Title: [109067] trunk/Source/WebCore
- Revision
- 109067
- Author
- commit-qu...@webkit.org
- Date
- 2012-02-27 20:17:32 -0800 (Mon, 27 Feb 2012)
Log Message
[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=79622
For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.
Patch by Yoshifumi Inoue <yo...@chromium.org> on 2012-02-27
Reviewed by Adam Barth.
No new tests. No behavior change.
* html/HTMLInputElement.idl: Reorder and remove obsolete comments.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (109066 => 109067)
--- trunk/Source/WebCore/ChangeLog 2012-02-28 03:52:02 UTC (rev 109066)
+++ trunk/Source/WebCore/ChangeLog 2012-02-28 04:17:32 UTC (rev 109067)
@@ -1,3 +1,17 @@
+2012-02-27 Yoshifumi Inoue <yo...@chromium.org>
+
+ [Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
+ https://bugs.webkit.org/show_bug.cgi?id=79622
+
+ For ease of maintainability, this patch reorders attributes and methods declaration
+ matching with specification.
+
+ Reviewed by Adam Barth.
+
+ No new tests. No behavior change.
+
+ * html/HTMLInputElement.idl: Reorder and remove obsolete comments.
+
2012-02-27 Luke Macpherson <macpher...@chromium.org>
Sort CSSStyleSelector property handler constructors by CSS property name.
Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (109066 => 109067)
--- trunk/Source/WebCore/html/HTMLInputElement.idl 2012-02-28 03:52:02 UTC (rev 109066)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl 2012-02-28 04:17:32 UTC (rev 109067)
@@ -21,36 +21,33 @@
module html {
interface HTMLInputElement : HTMLElement {
- attribute [TreatNullAs=NullString] DOMString defaultValue;
+ attribute [Reflect] DOMString accept;
+ attribute [Reflect] DOMString alt;
+ attribute [Reflect] DOMString autocomplete;
+ attribute [Reflect] boolean autofocus;
attribute [Reflect=checked] boolean defaultChecked;
+ attribute boolean checked;
attribute [Reflect] DOMString dirName;
+ attribute [Reflect] boolean disabled;
readonly attribute HTMLFormElement form;
+ readonly attribute FileList files;
attribute [Reflect, URL] DOMString formAction;
attribute [TreatNullAs=NullString] DOMString formEnctype;
attribute [TreatNullAs=NullString] DOMString formMethod;
attribute [Reflect] boolean formNoValidate;
attribute [Reflect] DOMString formTarget;
- readonly attribute ValidityState validity;
- attribute [Reflect] DOMString accept;
- attribute [Reflect] DOMString align;
- attribute [Reflect] DOMString alt;
- attribute boolean checked;
- attribute [Reflect] boolean disabled;
- attribute [Reflect] boolean autofocus;
- attribute [Reflect] DOMString autocomplete;
+ attribute boolean indeterminate;
readonly attribute [Conditional=DATALIST] HTMLElement list;
attribute [Reflect] DOMString max;
attribute long maxLength setter raises(DOMException);
attribute [Reflect] DOMString min;
attribute [Reflect] boolean multiple;
- attribute [Conditional=DIRECTORY_UPLOAD, Reflect] boolean webkitdirectory;
attribute [Reflect] DOMString name;
attribute [Reflect] DOMString pattern;
attribute [Reflect] DOMString placeholder;
attribute [Reflect] boolean readOnly;
attribute [Reflect] boolean required;
#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
- attribute [Reflect] DOMString accessKey;
attribute [ObjCImplementedAsUnsignedLong] DOMString size; // DOM level 2 changed this to a long, but ObjC API is a string
#else
attribute unsigned long size; // Changed string -> long -> unsigned long
@@ -58,39 +55,28 @@
attribute [Reflect, URL] DOMString src;
attribute [Reflect] DOMString step;
attribute [TreatNullAs=NullString] DOMString type; // readonly dropped as part of DOM level 2
- attribute [Reflect] DOMString useMap;
+ attribute [TreatNullAs=NullString] DOMString defaultValue;
attribute [TreatNullAs=NullString] DOMString value;
#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
attribute Date valueAsDate setter raises(DOMException);
#endif
attribute double valueAsNumber setter raises(DOMException);
- readonly attribute [Conditional=DATALIST] HTMLOptionElement selectedOption;
- attribute [Reflect] boolean incremental;
void stepUp(in [Optional] long n) raises(DOMException);
void stepDown(in [Optional] long n) raises(DOMException);
readonly attribute boolean willValidate;
+ readonly attribute ValidityState validity;
readonly attribute DOMString validationMessage;
boolean checkValidity();
void setCustomValidity(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString error);
- void select();
-#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
- void click();
-#endif
+ readonly attribute NodeList labels;
-#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT
- void setValueForUser(in [TreatNullAs=NullString] DOMString value);
-#endif
-
- // WinIE extension:
- attribute boolean indeterminate;
-
+ void select();
attribute [Custom] long selectionStart;
attribute [Custom] long selectionEnd;
attribute [Custom] DOMString selectionDirection;
-
#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
[Custom] void setSelectionRange(in long start, in long end);
#else
@@ -99,18 +85,33 @@
in [Optional] DOMString direction);
#endif
-#if defined(LANGUAGE_OBJECTIVE_C)
+ // Non-standard attributes
+ attribute [Reflect] DOMString align;
+ attribute [Conditional=DIRECTORY_UPLOAD, Reflect] boolean webkitdirectory;
+ attribute [Reflect] DOMString useMap;
+ readonly attribute [Conditional=DATALIST] HTMLOptionElement selectedOption;
+ attribute [Reflect] boolean incremental;
+ attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitSpeech;
+ attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitGrammar;
+ attribute [Conditional=INPUT_SPEECH, NotEnumerable] EventListener onwebkitspeechchange;
+
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
+ attribute [Reflect] DOMString accessKey;
+#endif
+
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
+ void click();
+#endif
+
+#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT
+ void setValueForUser(in [TreatNullAs=NullString] DOMString value);
+#endif
+
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
// Objective-C extension:
readonly attribute DOMString altDisplayString;
readonly attribute URL absoluteImageURL;
#endif
- readonly attribute FileList files;
- readonly attribute NodeList labels;
-
- attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitSpeech;
- attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitGrammar;
- attribute [Conditional=INPUT_SPEECH, NotEnumerable] EventListener onwebkitspeechchange;
};
-
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
