Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db3dda48a43a34e427ab0078b8aca082600bd4de
https://github.com/WebKit/WebKit/commit/db3dda48a43a34e427ab0078b8aca082600bd4de
Author: Philippe Normand <ph...@igalia.com>
Date: 2023-06-01 (Thu, 01 Jun 2023)
Changed paths:
M
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp
M
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
Log Message:
-----------
[GStreamer][MediaStream] Crash in mock video capture source
https://bugs.webkit.org/show_bug.cgi?id=257538
Reviewed by Xabier Rodriguez-Calvar.
The main issue was bad handling of the frame metadata, using the -> on an empty
std::optional<>
doesn't work as intended.
Also include a few drive-by fixes and cleanups found while trying to guess
where the issue was, from
corrupted release gdb backtrace...
*
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockRealtimeVideoSourceGStreamer::updateSampleBuffer):
*
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::videoFrameRotation const):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
Canonical link: https://commits.webkit.org/264783@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
