Title: [109234] trunk/Source/WebKit2
- Revision
- 109234
- Author
- wei...@apple.com
- Date
- 2012-02-29 11:40:24 -0800 (Wed, 29 Feb 2012)
Log Message
When invoking Lookup while zoomed in, the highlighted word renders out of line
<rdar://problem/10812527>
Reviewed by Simon Fraser.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
Make sure to scale the ascent when determining the origin for the overlay.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (109233 => 109234)
--- trunk/Source/WebKit2/ChangeLog 2012-02-29 19:08:24 UTC (rev 109233)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-29 19:40:24 UTC (rev 109234)
@@ -1,3 +1,14 @@
+2012-02-29 Sam Weinig <s...@webkit.org>
+
+ When invoking Lookup while zoomed in, the highlighted word renders out of line
+ <rdar://problem/10812527>
+
+ Reviewed by Simon Fraser.
+
+ * WebProcess/WebPage/mac/WebPageMac.mm:
+ (WebKit::WebPage::performDictionaryLookupForRange):
+ Make sure to scale the ascent when determining the origin for the overlay.
+
2012-02-29 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (109233 => 109234)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2012-02-29 19:08:24 UTC (rev 109233)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2012-02-29 19:40:24 UTC (rev 109234)
@@ -539,7 +539,7 @@
DictionaryPopupInfo dictionaryPopupInfo;
dictionaryPopupInfo.type = type;
- dictionaryPopupInfo.origin = FloatPoint(rangeRect.x(), rangeRect.y() + style->fontMetrics().ascent());
+ dictionaryPopupInfo.origin = FloatPoint(rangeRect.x(), rangeRect.y() + (style->fontMetrics().ascent() * pageScaleFactor()));
dictionaryPopupInfo.fontInfo.fontAttributeDictionary = fontDescriptorAttributes;
#if !defined(BUILDING_ON_SNOW_LEOPARD)
dictionaryPopupInfo.options = (CFDictionaryRef)options;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
