Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 892935d504cf4b301a232d0b4399b5ac97f67900
https://github.com/WebKit/WebKit/commit/892935d504cf4b301a232d0b4399b5ac97f67900
Author: Anne van Kesteren <ann...@annevk.nl>
Date: 2023-06-08 (Thu, 08 Jun 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssimportrule-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssimportrule.html
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/selectorSerialize-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/selectorSerialize.html
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/xml-stylesheet-pi-in-doctype.xhtml
M Source/WebCore/css/CSSSelector.cpp
Log Message:
-----------
Correct serialization of Selectors
https://bugs.webkit.org/show_bug.cgi?id=184604
rdar://97092572
Reviewed by Antti Koivisto and Tim Nguyen.
We did not use serializeIdentifier for qualified name prefixes and
local names. E.g., x:x was not serialized as x\:x. This was previously
attempted, but it would do the wrong thing for * and thus backed out.
So now we do not escape when prefix or local name is *.
The only edge case remaining is whether the * and \* inputs should mean
the same thing. https://github.com/w3c/csswg-drafts/issues/8911 will
eventually address this.
Meanwhile this seems like a solid improvement.
Also synchronize web-platform-tests/css/cssom up to upstream commit
57c5006103146974adb3af50d325c3b6ce7153d0 for real this time.
264934@main missed a couple changes.
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssimportrule-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssimportrule.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/selectorSerialize-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/selectorSerialize.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/xml-stylesheet-pi-in-doctype.xhtml:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::serializeIdentifierOrStar):
(WebCore::CSSSelector::selectorText const):
Canonical link: https://commits.webkit.org/264980@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
