Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 644d6535804c8d7a1ad1204e4203ba2462acf0a8 https://github.com/WebKit/WebKit/commit/644d6535804c8d7a1ad1204e4203ba2462acf0a8 Author: Mike Wyrzykowski <mwyrzykow...@apple.com> Date: 2023-06-09 (Fri, 09 Jun 2023)
Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: ----------- Highlight appears behind dictated text https://bugs.webkit.org/show_bug.cgi?id=257874 radar://110492195 Reviewed by Aditya Keerthi. 264903@main introduced a regression where the following code: auto initialUnderlines = extractInitialUnderlines(string); underlines = !initialUnderlines.isEmpty() ? initialUnderlines : extractUnderlines(string); was changed to: underlines = compositionUnderlines(string); but compositionUnderlines doesn't populate the underlines when they are otherwise empty. Re-introduce code removed from 264903@main and this issue appears resolved. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration setAllowsInlinePredictions:]): (-[WKWebViewConfiguration allowsInlinePredictions]): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::extractUnderlines): (WebKit::WebViewImpl::setMarkedText): Canonical link: https://commits.webkit.org/265031@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes