Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: caba77f65b6ccee5ab9eb1d37889a80436cf2dae https://github.com/WebKit/WebKit/commit/caba77f65b6ccee5ab9eb1d37889a80436cf2dae Author: Alex Christensen <achristen...@apple.com> Date: 2023-06-09 (Fri, 09 Jun 2023)
Changed paths: M LayoutTests/http/tests/navigation/process-swap-window-open.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h M Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp M Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h M Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm M Source/WebKit/UIProcess/WebProcessPool.cpp M Tools/MiniBrowser/mac/AppDelegate.m M Tools/MiniBrowser/mac/SettingsController.h M Tools/MiniBrowser/mac/SettingsController.m M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestOptions.cpp M Tools/WebKitTestRunner/TestOptions.h M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Log Message: ----------- Replace ProcessPoolConfiguration SPI with yaml-generated runtime flag for enabling window.open process swap https://bugs.webkit.org/show_bug.cgi?id=257915 rdar://110550079 Reviewed by J Pascoe. The SPI was only used for a few API tests which continue to pass and 1 layout test which continues to be skipped. This makes the feature flag cleaner and fit into our feature flag infrastructure better. It is still off by default. * LayoutTests/http/tests/navigation/process-swap-window-open.html: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::copy): * Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h: * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp: (WKContextConfigurationProcessSwapsOnWindowOpenWithOpener): Deleted. (WKContextConfigurationSetProcessSwapsOnWindowOpenWithOpener): Deleted. * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h: * Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: * Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: (-[_WKProcessPoolConfiguration setProcessSwapsOnWindowOpenWithOpener:]): Deleted. (-[_WKProcessPoolConfiguration processSwapsOnWindowOpenWithOpener]): Deleted. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigationInternal): * Tools/MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate defaultConfiguration]): * Tools/MiniBrowser/mac/SettingsController.h: * Tools/MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu:]): (-[SettingsController validateMenuItem:]): (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]): Deleted. (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]): Deleted. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: (TEST): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::generateContextConfiguration const): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::enableProcessSwapOnNavigation const): (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): (WTR::TestOptions::enableProcessSwapOnWindowOpen const): Deleted. * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformSpecificFeatureOverridesDefaultsForTest const): Canonical link: https://commits.webkit.org/265042@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes