Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 49aa2ac7ade4054f7eb0d59e8888934494c0337e https://github.com/WebKit/WebKit/commit/49aa2ac7ade4054f7eb0d59e8888934494c0337e Author: Simon Fraser <simon.fra...@apple.com> Date: 2023-07-28 (Fri, 28 Jul 2023)
Changed paths: M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/PlatformCALayer.h M Source/WebCore/platform/graphics/ca/PlatformCALayer.mm M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm Log Message: ----------- Have PlatformCALayer keep a strong ref to its mask layer https://bugs.webkit.org/show_bug.cgi?id=259605 rdar://113041840 Reviewed by Tim Horton. PlatformCALayerRemote holds a raw pointer to its mask layer. This layer is retained by other means, but it's simpler to have it hold a strong reference. Rather than give PlatformCALayerRemote different ownership behavior to PlatformCALayerCocoa, move the ownership of m_maskLayer into the base class. Also rename setMask -> setMaskLayer which is more descriptive. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateClippingStrategy): (WebCore::GraphicsLayerCA::updateContentsRects): (WebCore::GraphicsLayerCA::updateMaskLayer): * Source/WebCore/platform/graphics/ca/PlatformCALayer.h: * Source/WebCore/platform/graphics/ca/PlatformCALayer.mm: (WebCore::PlatformCALayer::setMaskLayer): * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::setMaskLayer): (WebCore::PlatformCALayerCocoa::setMask): Deleted. * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm: (WebKit::PlatformCALayerRemote::recursiveBuildTransaction): (WebKit::PlatformCALayerRemote::setMaskLayer): (WebKit::PlatformCALayerRemote::setMask): Deleted. Canonical link: https://commits.webkit.org/266405@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes