Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20b21450ef4de9f80bd2d7ed1263294cb4799ccf https://github.com/WebKit/WebKit/commit/20b21450ef4de9f80bd2d7ed1263294cb4799ccf Author: Jer Noble <jer.no...@apple.com> Date: 2023-08-03 (Thu, 03 Aug 2023)
Changed paths: M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: ----------- [Cocoa] Add logging for Element Fullscreen path inside WebKit https://bugs.webkit.org/show_bug.cgi?id=259761 rdar://113308053 Reviewed by Simon Fraser. Add LoggerHelper-style logging to WebFullScreenManager, WebFullScreenManagerProxy, and WKFullScreenWindowController (iOS). Drive-by Fix: Ensure the WebPage parameter to the WebFullScreenManagerProxy::create() method is non-null by making it a reference (&) rather than pointer (*). * Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy): (WebKit::WebFullScreenManagerProxy::willEnterFullScreen): (WebKit::WebFullScreenManagerProxy::didEnterFullScreen): (WebKit::WebFullScreenManagerProxy::willExitFullScreen): (WebKit::WebFullScreenManagerProxy::didExitFullScreen): (WebKit::WebFullScreenManagerProxy::requestRestoreFullScreen): (WebKit::WebFullScreenManagerProxy::requestExitFullScreen): (WebKit::WebFullScreenManagerProxy::logChannel const): * Source/WebKit/UIProcess/WebFullScreenManagerProxy.h: (WebKit::WebFullScreenManagerProxy::logger const): (WebKit::WebFullScreenManagerProxy::logIdentifier const): (WebKit::WebFullScreenManagerProxy::logClassName const): * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (WTF::LogArgument<WebKit::FullScreenState>::toString): (-[WKFullScreenWindowController initWithWebView:]): (-[WKFullScreenWindowController enterFullScreen:]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController requestRestoreFullScreen]): (-[WKFullScreenWindowController requestExitFullScreen]): (-[WKFullScreenWindowController exitFullScreen]): (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController _completedExitFullScreen]): (-[WKFullScreenWindowController close]): (-[WKFullScreenWindowController webViewDidRemoveFromSuperviewWhileInFullscreen]): (-[WKFullScreenWindowController didEnterPictureInPicture]): (-[WKFullScreenWindowController didExitPictureInPicture]): (-[WKFullScreenWindowController _exitFullscreenImmediately]): (-[WKFullScreenWindowController _startToDismissFullscreenChanged:]): (-[WKFullScreenWindowController _dismissFullscreenViewController]): (-[WKFullScreenWindowController _interactiveDismissChanged:]): (-[WKFullScreenWindowController _interactivePinchDismissChanged:]): (-[WKFullScreenWindowController _configureSpatialFullScreenTransition]): (-[WKFullScreenWindowController _performSpatialFullScreenTransition:completionHandler:]): (-[WKFullScreenWindowController logIdentifier]): (-[WKFullScreenWindowController loggerPtr]): (-[WKFullScreenWindowController logChannel]): * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::create): (WebKit::WebFullScreenManager::WebFullScreenManager): (WebKit::WebFullScreenManager::invalidate): (WebKit::WebFullScreenManager::videoControlsManagerDidChange): (WebKit::WebFullScreenManager::setPIPStandbyElement): (WebKit::WebFullScreenManager::supportsFullScreen): (WebKit::WebFullScreenManager::enterFullScreenForElement): (WebKit::WebFullScreenManager::exitFullScreenForElement): (WebKit::WebFullScreenManager::willEnterFullScreen): (WebKit::WebFullScreenManager::didEnterFullScreen): (WebKit::WebFullScreenManager::willExitFullScreen): (WebKit::WebFullScreenManager::didExitFullScreen): (WebKit::WebFullScreenManager::requestRestoreFullScreen): (WebKit::WebFullScreenManager::requestExitFullScreen): (WebKit::WebFullScreenManager::close): (WebKit::WebFullScreenManager::logChannel const): * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::fullScreenManager): Canonical link: https://commits.webkit.org/266541@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes