Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6264aebbca8560834e3cf399543ab4dbbbc4855
      
https://github.com/WebKit/WebKit/commit/e6264aebbca8560834e3cf399543ab4dbbbc4855
  Author: Ahmad Saleem <ahmad.saleem792+git...@gmail.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    A LayoutTests/fast/table/overflowScroll-display-block-expected.html
    A LayoutTests/fast/table/overflowScroll-display-block.html
    A LayoutTests/fast/table/overflowScroll-expected.html
    A LayoutTests/fast/table/overflowScroll.html
    A LayoutTests/fast/table/table-different-overflow-values-2-expected.txt
    A LayoutTests/fast/table/table-different-overflow-values-2.html
    A LayoutTests/fast/table/table-different-overflow-values-expected.txt
    A LayoutTests/fast/table/table-different-overflow-values.html
    M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/overflow/computed-value-001-expected.txt
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  Compute the correct overflow-x and overflow-y values for table elements

https://bugs.webkit.org/show_bug.cgi?id=252422
rdar://problem/105850323

Reviewed by Antti Koivisto.

This patch is to align WebKit with Chromium / Blink and Firefox / Gecko.

Inspired & Test Merge: 
https://src.chromium.org/viewvc/blink?view=revision&revision=199640

This patch is to align WebKit to respect web-specification[1] & [2], which 
tells us that
display:table must treat anything other than hidden as visible and if 
overflow-x and
overflow-y are different, how they must be resolved. This latter part is 
already taken care
of, we're just allowing it to be applied to tables and table parts now.
Additionally, it allows us to have consolidated logic and simplify our code.

[1] https://drafts.csswg.org/css2/#overflow
[2] https://drafts.csswg.org/css-overflow-3/#propdef-overflow-x

* Source/WebCore/style/StyleAdjuster.cpp:
(isOverflowClipOrVisible): New static 'bool' helper function
(Adjuster::adjust): Update handling of "overflow-x" and "overflow-y" align with 
spec and
interop with other engines and simplify code with comments
* LayoutTests/fast/table/table-different-overflow-values.html: Add Test Case
* LayoutTests/fast/table/table-different-overflow-values-expected.txt: Add Test 
Case Expectation
* LayoutTests/fast/table/table-different-overflow-values-2.html: Add Test Case
* LayoutTests/fast/table/table-different-overflow-values-2-expected.txt: Add 
Test Case Expectation
* LayoutTests/fast/table/overflowScroll.html: Add Test Case
* LayoutTests/fast/table/overflowScroll-expected.html: Add Test Case Expectation
* LayoutTests/fast/table/overflowScroll-display-block.html: Add Test Case
* LayoutTests/fast/table/overflowScroll-display-block-expected.html: Add Test 
Case Expectation
* 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/overflow/computed-value-001-expected.txt:
 Rebaselined

Canonical link: https://commits.webkit.org/266560@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to