Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 958cc075a8612fc45d07e95dbfe9bad0547e3cd2 https://github.com/WebKit/WebKit/commit/958cc075a8612fc45d07e95dbfe9bad0547e3cd2 Author: Nikolaos Mouchtaris <nmouchta...@apple.com> Date: 2023-09-05 (Tue, 05 Sep 2023)
Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/motion/inheritance-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-parsing-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-parsing-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-shorthand-expected.txt M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSPrimitiveValue.cpp M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/calc/CSSCalcValue.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/platform/Length.cpp M Source/WebCore/platform/Length.h M Source/WebCore/platform/LengthFunctions.cpp M Source/WebCore/platform/LengthFunctions.h M Source/WebCore/rendering/MotionPath.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/style/StyleBuilderConverter.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp Log Message: ----------- [motion-path] Implement offset-position: normal https://bugs.webkit.org/show_bug.cgi?id=259988 rdar://113644765 Reviewed by Tim Nguyen. Have the inital value of offset-position default to using normal rather than auto. Currently implemented by adding a normal keyword to length and specifying this default value in RenderStyle::initialOffsetPosition. We should update normalPositionForOffsetPath in future patches to ensure the normal value is correct for path operations other than ray(). * LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-position-interpolation.html: * LayoutTests/imported/w3c/web-platform-tests/css/motion/inheritance.html: * Source/WebCore/animation/CSSPropertyAnimation.cpp: * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::create): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::isNormal): (WebCore::valueForPositionOrAuto): (WebCore::valueForOffsetShorthand): * Source/WebCore/css/calc/CSSCalcValue.cpp: (WebCore::createCSS): * Source/WebCore/platform/Length.cpp: (WebCore::operator<<): * Source/WebCore/platform/Length.h: (WebCore::Length::initialize): (WebCore::Length::isNormal const): * Source/WebCore/platform/LengthFunctions.cpp: (WebCore::valueForLength): (WebCore::floatValueForLength): * Source/WebCore/platform/LengthFunctions.h: (WebCore::minimumValueForLength): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeReplacedLogicalWidthUsing const): * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::initialOffsetPosition): * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertPositionOrAuto): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<Length>::encode): (IPC::ArgumentCoder<Length>::decode): Canonical link: https://commits.webkit.org/267657@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes