Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b3cad0ec99c990022c2a6d704a8b5cf1b951b74 https://github.com/WebKit/WebKit/commit/5b3cad0ec99c990022c2a6d704a8b5cf1b951b74 Author: Sam Sneddon <gsnedd...@apple.com> Date: 2023-09-06 (Wed, 06 Sep 2023)
Changed paths: M Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py A Tools/Scripts/webkitpy/common/net/bugzilla/ews.py A Tools/Scripts/webkitpy/common/net/bugzilla/results_fetcher.py A Tools/Scripts/webkitpy/common/net/bugzilla/results_fetcher_unittest.py M Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py M Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py M Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py Log Message: ----------- Split webkitpy.common.net.bugzilla.TestExpectationUpdater https://bugs.webkit.org/show_bug.cgi?id=261171 Reviewed by Jonathan Bedard. This patch does a number of things: * Split test_expectation_updater.TestExpectationUpdater into: * ews.EWS * results_fetcher.lookup_ews_results_from_bugzilla * test_expectation_updater.TestExpectationUpdater * Replace the MockZip with code that just generates a real ZipFile (revealing various places where we have str/bytes mixed on Python 3). This almost entirely is just moving code around; there should be no functional change. * Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py: * Tools/Scripts/webkitpy/common/net/bugzilla/ews.py: Added. (EWS): (EWS.__init__): (EWS.from_webapp_url): (EWS.builders): (EWS.steps_from_build_number): * Tools/Scripts/webkitpy/common/net/bugzilla/results_fetcher.py: Added. (_platform_name_for_bot): (_get_first_layout_test_step): (_is_relevant_results): (lookup_ews_results): (lookup_ews_results_from_bugzilla_patch): (lookup_ews_results_from_bugzilla): * Tools/Scripts/webkitpy/common/net/bugzilla/results_fetcher_unittest.py: Added. (MockAttachment): (MockAttachment.__init__): (MockAttachment.contents): (MockAttachment.is_patch): (MockAttachment.is_obsolete): (MockBugzilla): (MockBugzilla.fetch_bug): (MockBugzilla.attachments): (MockRequestsGet): (MockRequestsGet.__init__): (MockRequestsGet.content): (MockRequestsGet.text): (MockRequestsGet.raise_for_status): (MockRequestsGet.json): (ResultsFetcherTest): (ResultsFetcherTest.test_is_relevant_results): (ResultsFetcherTest.test_lookup_ews_results_from_bugzilla): * Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: (TestExpectationUpdater.__init__): (TestExpectationUpdater._tests_to_update): (TestExpectationUpdater._file_content_if_exists): (TestExpectationUpdater._update_for_generic_bot): (TestExpectationUpdater._update_for_platform_specific_bot): (TestExpectationUpdater.do_update): (main): (TestExpectationUpdater._platform_name): Deleted. (TestExpectationUpdater._get_layout_tests_run): Deleted. (TestExpectationUpdater._lookup_ews_results): Deleted. * Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: (_make_zip_filelike): (MockRequestsGet): (MockRequestsGet.__init__): (MockRequestsGet.content): (MockRequestsGet.text): (MockRequestsGet.raise_for_status): (MockRequestsGet.json): (TestExpectationUpdaterTest.test_update_test_expectations): (MockAttachment): Deleted. (MockAttachment.__init__): Deleted. (MockAttachment.contents): Deleted. (MockAttachment.is_patch): Deleted. (MockAttachment.is_obsolete): Deleted. (MockBugzilla): Deleted. (MockBugzilla.fetch_bug): Deleted. (MockBugzilla.attachments): Deleted. (MockZip): Deleted. (MockZip.__init__): Deleted. (MockZip.unzip): Deleted. (MockZip.read): Deleted. * Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: (has_json_wrapper): Canonical link: https://commits.webkit.org/267690@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes