Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40db266105fd16b22d7ed2a997c2619f6a5c936e https://github.com/WebKit/WebKit/commit/40db266105fd16b22d7ed2a997c2619f6a5c936e Author: Alan Baradlay <za...@apple.com> Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/layout/formattingContexts/FormattingContext.h M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp M Source/WebCore/layout/formattingContexts/FormattingQuirks.h M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.h M Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.h M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp R Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp R Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp A Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp A Source/WebCore/layout/formattingContexts/inline/InlineQuirks.h M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp M Source/WebCore/layout/formattingContexts/table/TableFormattingContext.h Log Message: ----------- [IFC][Cleanup] Rename InlineFormattingQuirks to InlineQuirks (and detach it from base class) https://bugs.webkit.org/show_bug.cgi?id=262469 Reviewed by Antti Koivisto. As it turns out, quirks are not really shared between formatting contexts (no need for having a base class) * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/layout/formattingContexts/FormattingContext.h: * Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp: (WebCore::Layout::FormattingGeometry::computedHeightValue const): * Source/WebCore/layout/formattingContexts/FormattingQuirks.h: (WebCore::Layout::FormattingQuirks::isBlockFormattingQuirks const): (WebCore::Layout::FormattingQuirks::isInlineFormattingQuirks const): Deleted. * Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.h: (WebCore::Layout::BlockFormattingContext::formattingQuirks const): * Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.h: * Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h: * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::InlineFormattingContext): * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h: * Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp: (WebCore::Layout::InlineFormattingGeometry::inlineLevelBoxAffectsLineBox const): (WebCore::Layout::InlineFormattingGeometry::initialLineHeight const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::placeInlineAndFloatContent): (WebCore::Layout::LineBuilder::floatConstrainedRect const): (WebCore::Layout::LineBuilder::adjustLineRectForInitialLetterIfApplicable): * Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp: Renamed from Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp. (WebCore::Layout::InlineQuirks::InlineQuirks): (WebCore::Layout::InlineQuirks::trailingNonBreakingSpaceNeedsAdjustment const): (WebCore::Layout::InlineQuirks::initialLineHeight const): (WebCore::Layout::InlineQuirks::lineBreakBoxAffectsParentInlineBox): (WebCore::Layout::InlineQuirks::inlineBoxAffectsLineBox const): (WebCore::Layout::InlineQuirks::initialLetterAlignmentOffset const): (WebCore::Layout::InlineQuirks::adjustedRectForLineGridLineAlign const): * Source/WebCore/layout/formattingContexts/inline/InlineQuirks.h: Renamed from Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h. (WebCore::Layout::InlineQuirks::formattingContext const): * Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp: (WebCore::Layout::TextOnlySimpleLineBuilder::handleLineEnding): * Source/WebCore/layout/formattingContexts/table/TableFormattingContext.h: Canonical link: https://commits.webkit.org/268728@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes