Title: [109827] trunk/Source/WebKit/chromium
- Revision
- 109827
- Author
- commit-qu...@webkit.org
- Date
- 2012-03-05 17:38:58 -0800 (Mon, 05 Mar 2012)
Log Message
[Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=80089
Change class hierarchy of WebOptionElement to match with specification.
Patch by Yoshifumi Inoue <yo...@chromium.org> on 2012-03-05
Reviewed by Darin Fisher.
* public/WebOptionElement.h: Replace to WebElement from WebFormControlElement
(WebKit::WebOptionElement::WebOptionElement):
(WebKit::WebOptionElement::operator=):
(WebKit::WebOptionElement::assign):
* src/WebOptionElement.cpp:
(WebKit::WebOptionElement::WebOptionElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (109826 => 109827)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-06 01:35:47 UTC (rev 109826)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-06 01:38:58 UTC (rev 109827)
@@ -1,3 +1,19 @@
+2012-03-05 Yoshifumi Inoue <yo...@chromium.org>
+
+ [Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement
+ https://bugs.webkit.org/show_bug.cgi?id=80089
+
+ Change class hierarchy of WebOptionElement to match with specification.
+
+ Reviewed by Darin Fisher.
+
+ * public/WebOptionElement.h: Replace to WebElement from WebFormControlElement
+ (WebKit::WebOptionElement::WebOptionElement):
+ (WebKit::WebOptionElement::operator=):
+ (WebKit::WebOptionElement::assign):
+ * src/WebOptionElement.cpp:
+ (WebKit::WebOptionElement::WebOptionElement):
+
2012-03-05 Joshua Bell <jsb...@chromium.org>
IndexedDB: Handle LevelDB database corruption
Modified: trunk/Source/WebKit/chromium/public/WebOptionElement.h (109826 => 109827)
--- trunk/Source/WebKit/chromium/public/WebOptionElement.h 2012-03-06 01:35:47 UTC (rev 109826)
+++ trunk/Source/WebKit/chromium/public/WebOptionElement.h 2012-03-06 01:38:58 UTC (rev 109827)
@@ -31,7 +31,7 @@
#ifndef WebOptionElement_h
#define WebOptionElement_h
-#include "WebFormControlElement.h"
+#include "WebElement.h"
#include "platform/WebVector.h"
#if WEBKIT_IMPLEMENTATION
@@ -41,17 +41,17 @@
namespace WebKit {
// Provides readonly access to some properties of a DOM option element node.
-class WebOptionElement : public WebFormControlElement {
+class WebOptionElement : public WebElement {
public:
- WebOptionElement() : WebFormControlElement() { }
- WebOptionElement(const WebOptionElement& element) : WebFormControlElement(element) { }
+ WebOptionElement() : WebElement() { }
+ WebOptionElement(const WebOptionElement& element) : WebElement(element) { }
WebOptionElement& operator=(const WebOptionElement& element)
{
- WebFormControlElement::assign(element);
+ WebElement::assign(element);
return *this;
}
- void assign(const WebOptionElement& element) { WebFormControlElement::assign(element); }
+ void assign(const WebOptionElement& element) { WebElement::assign(element); }
WEBKIT_EXPORT void setValue(const WebString&);
WEBKIT_EXPORT WebString value() const;
Modified: trunk/Source/WebKit/chromium/src/WebOptionElement.cpp (109826 => 109827)
--- trunk/Source/WebKit/chromium/src/WebOptionElement.cpp 2012-03-06 01:35:47 UTC (rev 109826)
+++ trunk/Source/WebKit/chromium/src/WebOptionElement.cpp 2012-03-06 01:38:58 UTC (rev 109827)
@@ -83,7 +83,7 @@
}
WebOptionElement::WebOptionElement(const PassRefPtr<HTMLOptionElement>& elem)
- : WebFormControlElement(elem)
+ : WebElement(elem)
{
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
