Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4559d6134a8d08538ad0a54f80f9651b9785f128 https://github.com/WebKit/WebKit/commit/4559d6134a8d08538ad0a54f80f9651b9785f128 Author: Andres Gonzalez <andresg...@apple.com> Date: 2024-01-10 (Wed, 10 Jan 2024)
Changed paths: R LayoutTests/accessibility/gtk/relation-types-expected.txt R LayoutTests/accessibility/gtk/relation-types.html A LayoutTests/accessibility/relationships-expected.txt A LayoutTests/accessibility/relationships.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXLogger.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: ----------- AX: Add test coverage for aria-based relationships on Mac. https://bugs.webkit.org/show_bug.cgi?id=267271 <rdar://problem/120712164> Reviewed by Chris Fleizach. Re-wrote and moved accessibility/gtk/relation-types.html to accessibility/relationships.html. This test was being executed only for GTK platforms. Now it is for Mac as well. The test was re-written using up-to-date AX standards. A number of AccessibilityUIElement methods were added to access the individual relationships. * LayoutTests/accessibility/gtk/relation-types-expected.txt: Moved to accessibility/. * LayoutTests/accessibility/gtk/relation-types.html: Moved to accessibility/. * LayoutTests/accessibility/relationships-expected.txt: Added. * LayoutTests/accessibility/relationships.html: Added. * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::AXLogger::log): * Source/WebCore/accessibility/AXLogger.h: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::addRelation): (WebCore::AXObjectCache::removeRelations): * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): (WTR::AccessibilityUIElement::controllerForElementAtIndex): (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex): (WTR::AccessibilityUIElement::descriptionForElementAtIndex): (WTR::AccessibilityUIElement::detailsElements const): (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex): (WTR::AccessibilityUIElement::detailsForElementAtIndex): (WTR::AccessibilityUIElement::errorMessageElements const): (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex): (WTR::AccessibilityUIElement::errorMessageForElementAtIndex): (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): (WTR::AccessibilityUIElement::flowFromElementAtIndex): (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex): (WTR::AccessibilityUIElement::labelForElementAtIndex): (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): (WTR::AccessibilityUIElement::ownerElementAtIndex): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: (WTR::AccessibilityUIElement::detailsElements const): Deleted. (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex): Deleted. (WTR::AccessibilityUIElement::errorMessageElements const): Deleted. (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex): Deleted. * Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp: (WTR::AccessibilityUIElement::ownerElementAtIndex): (WTR::AccessibilityUIElement::flowFromElementAtIndex): (WTR::AccessibilityUIElement::controllerElementAtIndex): (WTR::AccessibilityUIElement::labelForElementAtIndex): (WTR::AccessibilityUIElement::descriptionForElementAtIndex): (WTR::AccessibilityUIElement::detailsForElementAtIndex): (WTR::AccessibilityUIElement::errorMessageForElementAtIndex): (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex): Deleted. (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex): Deleted. * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::controllerElementAtIndex): (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex): (WTR::AccessibilityUIElement::descriptionForElementAtIndex): (WTR::AccessibilityUIElement::detailsElements const): (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex): (WTR::AccessibilityUIElement::detailsForElementAtIndex): (WTR::AccessibilityUIElement::errorMessageElements const): (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex): (WTR::AccessibilityUIElement::errorMessageForElementAtIndex): (WTR::AccessibilityUIElement::flowFromElementAtIndex): (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex): (WTR::AccessibilityUIElement::labelForElementAtIndex): (WTR::AccessibilityUIElement::ownerElementAtIndex): (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Canonical link: https://commits.webkit.org/272871@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes