Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86b022b127ea411def2339f0fec126ae7b9d36d6 https://github.com/WebKit/WebKit/commit/86b022b127ea411def2339f0fec126ae7b9d36d6 Author: Tim Horton <thor...@apple.com> Date: 2024-01-22 (Mon, 22 Jan 2024)
Changed paths: M Source/WebKit/Shared/mac/PDFContextMenu.h M Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: ----------- [UnifiedPDF] Implement HUD actions https://bugs.webkit.org/show_bug.cgi?id=267910 rdar://118241818 Reviewed by Richard Robinson. Implement Open In... and Download in the HUD, and Open In... in the context menu. * Source/WebKit/Shared/mac/PDFContextMenu.h: * Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in: * Source/WebKit/UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::showPDFContextMenu): Rename openInPreviewIndex to openInPreviewTag since that's what it is in practice. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::handleContextMenuEvent): (WebKit::PDFPlugin::liveData const): (WebKit::PDFPlugin::save): Deleted. (WebKit::PDFPlugin::openWithPreview): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::createPDFDocument): (WebKit::PDFPluginBase::originalData const): (WebKit::PDFPluginBase::save): (WebKit::PDFPluginBase::openWithPreview): Hoist these to PDFPluginBase. (WebKit::PDFPluginBase::rawData const): Deleted. Rename rawData to originalData to properly convey what is special about it. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::liveData const): Temporarily implement liveData() interms of originalData() until we have annotation support implemented. (WebKit::UnifiedPDFPlugin::createContextMenu const): (WebKit::UnifiedPDFPlugin::save): Deleted. (WebKit::UnifiedPDFPlugin::openWithPreview): Deleted. Canonical link: https://commits.webkit.org/273346@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes