Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f62dc2ae6c6b869b3feb37de4941b9f24afdaa95 https://github.com/WebKit/WebKit/commit/f62dc2ae6c6b869b3feb37de4941b9f24afdaa95 Author: Alex Christensen <achristen...@apple.com> Date: 2024-01-24 (Wed, 24 Jan 2024)
Changed paths: M Source/WebCore/dom/SecurityContext.h M Source/WebCore/loader/CrossOriginOpenerPolicy.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/EmptyFrameLoaderClient.h M Source/WebCore/loader/FrameLoaderClient.h M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/loader/PolicyChecker.cpp M Source/WebCore/loader/PolicyChecker.h M Source/WebKit/Shared/LoadParameters.h M Source/WebKit/Shared/NavigationActionData.h M Source/WebKit/Shared/WebHitTestResultData.cpp M Source/WebKit/Shared/WebHitTestResultData.h M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm Log Message: ----------- WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction shouldn't interact with a LocalFrame https://bugs.webkit.org/show_bug.cgi?id=267984 Reviewed by Chris Dumez. The Frame may be a RemoteFrame. This is part of untangling this navigation flow so I can reuse its pieces better. * Source/WebCore/dom/SecurityContext.h: * Source/WebCore/loader/CrossOriginOpenerPolicy.h: * Source/WebCore/loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebCore/loader/EmptyFrameLoaderClient.h: * Source/WebCore/loader/FrameLoaderClient.h: * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/loader/PolicyChecker.cpp: (WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy): (WebCore::FrameLoader::PolicyChecker::hitTestResult): (WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy): * Source/WebCore/loader/PolicyChecker.h: * Source/WebKit/Shared/LoadParameters.h: * Source/WebKit/Shared/NavigationActionData.h: * Source/WebKit/Shared/WebHitTestResultData.cpp: (WebKit::WebHitTestResultData::fromNavigationActionAndLocalFrame): Deleted. * Source/WebKit/Shared/WebHitTestResultData.h: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/273419@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes