Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3c7518b1394db37cb46e4c00c9272d382eacb2f https://github.com/WebKit/WebKit/commit/a3c7518b1394db37cb46e4c00c9272d382eacb2f Author: Nikolas Zimmermann <nzimmerm...@igalia.com> Date: 2024-02-03 (Sat, 03 Feb 2024)
Changed paths: M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/svg/RenderSVGBlock.cpp M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp M Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGInline.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.h M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.h M Source/WebCore/rendering/svg/RenderSVGShape.cpp M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/rendering/svg/SVGResourcesCache.cpp M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h Log Message: ----------- [LBSE] Code cleanup after implementing all but one resource https://bugs.webkit.org/show_bug.cgi?id=268615 Reviewed by Rob Buis. Remove all usage of SVGRenderingContext.h / SVGResources.h / SVGResourcesCache.h, that is legacy-only code, from LBSE. Turn all static methods in SVGResourcesCache to release assertion, to make sure none of these methods is called from LBSE. Covered by existing tests. * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::ReferencedSVGResources::referencedSVGResourceIDs): * Source/WebCore/rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::willBeDestroyed): (WebCore::RenderSVGBlock::styleDidChange): * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): * Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout): * Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp: * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::imageChanged): * Source/WebCore/rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::willBeDestroyed): (WebCore::RenderSVGInline::styleDidChange): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleDidChange): (WebCore::RenderSVGModelObject::willBeDestroyed): Deleted. * Source/WebCore/rendering/svg/RenderSVGModelObject.h: * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: * Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::layoutChildren): (WebCore::RenderSVGRoot::paintObject): (WebCore::RenderSVGRoot::willBeDestroyed): (WebCore::RenderSVGRoot::insertedIntoTree): Deleted. (WebCore::RenderSVGRoot::willBeRemovedFromTree): Deleted. (WebCore::RenderSVGRoot::styleDidChange): Deleted. (WebCore::RenderSVGRoot::addResourceForClientInvalidation): Deleted. * Source/WebCore/rendering/svg/RenderSVGRoot.h: * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::layout): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: * Source/WebCore/rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientLayoutChanged): (WebCore::SVGResourcesCache::clientStyleChanged): (WebCore::SVGResourcesCache::clientWasAddedToTree): (WebCore::SVGResourcesCache::clientWillBeRemovedFromTree): (WebCore::SVGResourcesCache::clientDestroyed): (WebCore::SVGResourcesCache::resourceDestroyed): * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::attachInternal): (WebCore::RenderTreeBuilder::detach): * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp: (WebCore::RenderTreeBuilder::SVG::attach): (WebCore::RenderTreeBuilder::SVG::detach): * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h: Canonical link: https://commits.webkit.org/274053@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes