Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40fc435f75be31167bf1228055f8f22aa03d3bf6 https://github.com/WebKit/WebKit/commit/40fc435f75be31167bf1228055f8f22aa03d3bf6 Author: Simon Fraser <simon.fra...@apple.com> Date: 2024-02-16 (Fri, 16 Feb 2024)
Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: ----------- [UnifiedPDF] Determine what kind of repaint a given annotation change requires https://bugs.webkit.org/show_bug.cgi?id=269623 rdar://123120061 Reviewed by Sammy Gill. Some annotation changes, like the blue textfield hover, only require us to repaint the hover overlay. Others, like checkboxes and radio buttons, require a regeneration of the cached tiles. To distinguish between these, change `ShouldRepaint` into `RepaintRequirement` which is used in an OptionSet<>. Pass this to `setNeedsRepaintInDocumentRect()` and have it invalidate the tiles only when necessary. Implement `repaintRequirementsForAnnotation()` so we know what kinds of repaint a given annotation requires. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::setNeedsRepaintInDocumentRect): (WebKit::UnifiedPDFPlugin::handleMouseEvent): (WebKit::UnifiedPDFPlugin::repaintRequirementsForAnnotation): (WebKit::UnifiedPDFPlugin::startTrackingAnnotation): (WebKit::UnifiedPDFPlugin::finishTrackingAnnotation): (WebKit::UnifiedPDFPlugin::setActiveAnnotation): (WebKit::AnnotationTrackingState::startAnnotationTracking): (WebKit::AnnotationTrackingState::finishAnnotationTracking): (WebKit::UnifiedPDFPlugin::setPDFChangedInDocumentRect): Deleted. (WebKit::AnnotationTrackingState::handleMouseDraggedOffTrackedAnnotation): Deleted. It was just a one-liner. Canonical link: https://commits.webkit.org/274911@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes