Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a691187c506e9f19e2a61adbf52585560d704d12
https://github.com/WebKit/WebKit/commit/a691187c506e9f19e2a61adbf52585560d704d12
Author: Jean-Yves Avenard <j...@apple.com>
Date: 2024-02-18 (Sun, 18 Feb 2024)
Changed paths:
M Source/WebCore/Modules/mediasource/MediaSource.cpp
Log Message:
-----------
[MSE] Intermittent crash with
imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html
https://bugs.webkit.org/show_bug.cgi?id=269656
rdar://123171059
Reviewed by Chris Dumez.
`MediaSource::ensureWeakOnHTMLMediaElementContext` took a strong ref to the
HTMLMediaElement but this code can be called while the HTMLMediaElement is
being destructed.
`ASSERT(!deletionHasBegun());`
We use a RefPtrAllowingPartiallyDestroyed instead which avoid the problem for
now.
Ideally the logic should be refactored to avoid calling the method in the first
place
if the HTMLMediaElement has gone away.
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::ensureWeakOnHTMLMediaElementContext const):
Canonical link: https://commits.webkit.org/274942@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
