Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35049289029387d9023e9f2a17986bf21629e857 https://github.com/WebKit/WebKit/commit/35049289029387d9023e9f2a17986bf21629e857 Author: Charlie Wolfe <charl...@apple.com> Date: 2024-02-19 (Mon, 19 Feb 2024)
Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: ----------- REGRESSION(274288@main): Null pointer dereference in `WebPageProxy::activityStateDidChange()` https://bugs.webkit.org/show_bug.cgi?id=269754 rdar://123032571 Reviewed by Chris Dumez. `m_pageClient` is protected in `decidePolicyForNavigationAction()`, but not passed to the created lambdas. When `Transaction` is destructed, `activityStateDidChange()` tries to create a strong reference to `m_pageClient`, but it may already be destroyed. We should pass `protectedPageClient` into the lambdas where `Transaction` is used. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/275019@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes