Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c0a7f074ef28ce5047f221780989c47e18e763c https://github.com/WebKit/WebKit/commit/7c0a7f074ef28ce5047f221780989c47e18e763c Author: Timothy Hatcher <timo...@apple.com> Date: 2024-02-21 (Wed, 21 Feb 2024)
Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.h M Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.h M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPortCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm Log Message: ----------- EmberJS Web Extension fails to detect Ember application. https://webkit.org/b/269816 rdar://problem/123338506 Reviewed by Brian Weinstein. DevTools extensions need to use a custom content world type, that is similar to Main but distinct since it has less APIs. Previously we were just using the ContentScript world type to limit the APIs. This prevented message passing from being delivered properly to the Inspector pages. We also need the pass the Inspector page, tab, and window identifiers to the web process so browser.devtools.inspectedWindow.tabId returns the correct value. * Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.h: (WebKit::toDebugString): * Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.serialization.in: * Source/WebKit/Shared/Extensions/WebExtensionContextParameters.h: * Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in: * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPortCocoa.mm: (WebKit::WebExtensionContext::portPostMessage): (WebKit::WebExtensionContext::firePortDisconnectEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm: (WebKit::WebExtensionContext::runtimeSendMessage): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::inspectorPageIdentifiers const): (WebKit::WebExtensionContext::wakeUpBackgroundContentIfNecessaryToFireEvents): (WebKit::WebExtensionContext::loadInspectorBackgroundPage): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp: (WebKit::WebExtensionContext::parameters const): (WebKit::WebExtensionContext::pageListensForEvent const): (WebKit::WebExtensionContext::processes const): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::processes const): (WebKit::WebExtensionContext::sendToProcessesForEvents const): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchRuntimeMessageEvent): (WebKit::WebExtensionContextProxy::dispatchRuntimeConnectEvent): * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm: (WebKit::WebExtensionContextProxy::toDOMWrapperWorld): * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm: (WebKit::WebExtensionControllerProxy::globalObjectIsAvailableForFrame): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp: (WebKit::WebExtensionContextProxy::tabIdentifier const): (WebKit::WebExtensionContextProxy::addInspectorPage): (WebKit::WebExtensionContextProxy::addInspectorPageIdentifier): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm: (TEST(WKWebExtensionAPIDevTools, MessagePassingToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, MessagePassingFromPanelToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, MessagePassingFromPanelToDevToolsBackground)): Added. (TEST(WKWebExtensionAPIDevTools, PortMessagePassingToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, PortMessagePassingFromPanelToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, PortMessagePassingFromPanelToDevToolsBackground)): Added. Canonical link: https://commits.webkit.org/275135@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes