Title: [110441] trunk
Revision
110441
Author
pfeld...@chromium.org
Date
2012-03-12 10:14:39 -0700 (Mon, 12 Mar 2012)

Log Message

Web Inspector: recognize Float*Array and Int*Array as arrays.
https://bugs.webkit.org/show_bug.cgi?id=80850

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-external-array.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::type):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

* inspector/console/console-external-array-expected.txt: Added.
* inspector/console/console-external-array.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (110440 => 110441)


--- trunk/LayoutTests/ChangeLog	2012-03-12 17:13:07 UTC (rev 110440)
+++ trunk/LayoutTests/ChangeLog	2012-03-12 17:14:39 UTC (rev 110441)
@@ -1,3 +1,13 @@
+2012-03-12  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: recognize Float*Array and Int*Array as arrays.
+        https://bugs.webkit.org/show_bug.cgi?id=80850
+
+        Reviewed by Vsevolod Vlasov.
+
+        * inspector/console/console-external-array-expected.txt: Added.
+        * inspector/console/console-external-array.html: Added.
+
 2012-03-12  Matt Falkenhagen  <fal...@chromium.org>
 
         Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale

Added: trunk/LayoutTests/inspector/console/console-external-array-expected.txt (0 => 110441)


--- trunk/LayoutTests/inspector/console/console-external-array-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/inspector/console/console-external-array-expected.txt	2012-03-12 17:14:39 UTC (rev 110441)
@@ -0,0 +1,23 @@
+CONSOLE MESSAGE: line 9: [object Int8Array]
+CONSOLE MESSAGE: line 10: [object Int16Array]
+CONSOLE MESSAGE: line 11: [object Int32Array]
+CONSOLE MESSAGE: line 12: [object Float32Array]
+CONSOLE MESSAGE: line 13: [object Float64Array]
+CONSOLE MESSAGE: line 15: [object Int8Array]
+CONSOLE MESSAGE: line 16: [object Int16Array]
+CONSOLE MESSAGE: line 17: [object Int32Array]
+CONSOLE MESSAGE: line 18: [object Float32Array]
+CONSOLE MESSAGE: line 19: [object Float64Array]
+Tests that console logging detects external arrays as arrays.
+
+console-external-array.html:9[0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+console-external-array.html:10[0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+console-external-array.html:11[0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+console-external-array.html:12[0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+console-external-array.html:13[0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
+console-external-array.html:15Int8Array[10]
+console-external-array.html:16Int16Array[10]
+console-external-array.html:17Int32Array[10]
+console-external-array.html:18Float32Array[10]
+console-external-array.html:19Float64Array[10]
+
Property changes on: trunk/LayoutTests/inspector/console/console-external-array-expected.txt
___________________________________________________________________

Added: svn:eol-style

Added: trunk/LayoutTests/inspector/console/console-external-array.html (0 => 110441)


--- trunk/LayoutTests/inspector/console/console-external-array.html	                        (rev 0)
+++ trunk/LayoutTests/inspector/console/console-external-array.html	2012-03-12 17:14:39 UTC (rev 110441)
@@ -0,0 +1,39 @@
+<html>
+<head>
+<script src=""
+<script src=""
+<script>
+
+function onload()
+{
+    console.log(new Int8Array(10));
+    console.log(new Int16Array(10));
+    console.log(new Int32Array(10));
+    console.log(new Float32Array(10));
+    console.log(new Float64Array(10));
+
+    console.dir(new Int8Array(10));
+    console.dir(new Int16Array(10));
+    console.dir(new Int32Array(10));
+    console.dir(new Float32Array(10));
+    console.dir(new Float64Array(10));
+
+    runTest();
+}
+
+function test()
+{
+    InspectorTest.dumpConsoleMessages();
+    InspectorTest.completeTest();
+}
+
+</script>
+</head>
+
+<body _onload_="onload()">
+<p>
+Tests that console logging detects external arrays as arrays.
+</p>
+
+</body>
+</html>
Property changes on: trunk/LayoutTests/inspector/console/console-external-array.html
___________________________________________________________________

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (110440 => 110441)


--- trunk/Source/WebCore/ChangeLog	2012-03-12 17:13:07 UTC (rev 110440)
+++ trunk/Source/WebCore/ChangeLog	2012-03-12 17:14:39 UTC (rev 110441)
@@ -1,3 +1,17 @@
+2012-03-12  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: recognize Float*Array and Int*Array as arrays.
+        https://bugs.webkit.org/show_bug.cgi?id=80850
+
+        Reviewed by Vsevolod Vlasov.
+
+        Test: inspector/console/console-external-array.html
+
+        * bindings/js/JSInjectedScriptHostCustom.cpp:
+        (WebCore::JSInjectedScriptHost::type):
+        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+        (WebCore::V8InjectedScriptHost::typeCallback):
+
 2012-03-12  Jocelyn Turcotte  <jocelyn.turco...@nokia.com>
 
         [TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.

Modified: trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp (110440 => 110441)


--- trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp	2012-03-12 17:13:07 UTC (rev 110440)
+++ trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp	2012-03-12 17:14:39 UTC (rev 110441)
@@ -44,8 +44,13 @@
 #include "InjectedScriptHost.h"
 #include "InspectorDebuggerAgent.h"
 #include "InspectorValues.h"
+#include "JSFloat32Array.h"
+#include "JSFloat64Array.h"
 #include "JSHTMLAllCollection.h"
 #include "JSHTMLCollection.h"
+#include "JSInt16Array.h"
+#include "JSInt32Array.h"
+#include "JSInt8Array.h"
 #include "JSNode.h"
 #include "JSNodeList.h"
 #include "JSStorage.h"
@@ -132,6 +137,10 @@
         return jsString(exec, String("array"));
     if (value.inherits(&JSHTMLCollection::s_info))
         return jsString(exec, String("array"));
+    if (value.inherits(&JSInt8Array::s_info) || value.inherits(&JSInt16Array::s_info) || value.inherits(&JSInt32Array::s_info))
+        return jsString(exec, String("array"));
+    if (value.inherits(&JSFloat32Array::s_info) || value.inherits(&JSFloat64Array::s_info))
+        return jsString(exec, String("array"));
     return jsUndefined();
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (110440 => 110441)


--- trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2012-03-12 17:13:07 UTC (rev 110440)
+++ trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2012-03-12 17:14:39 UTC (rev 110441)
@@ -40,9 +40,14 @@
 #include "V8Binding.h"
 #include "V8BindingState.h"
 #include "V8Database.h"
+#include "V8Float32Array.h"
+#include "V8Float64Array.h"
 #include "V8HTMLAllCollection.h"
 #include "V8HTMLCollection.h"
 #include "V8HiddenPropertyName.h"
+#include "V8Int16Array.h"
+#include "V8Int32Array.h"
+#include "V8Int8Array.h"
 #include "V8NodeList.h"
 #include "V8Node.h"
 #include "V8Proxy.h"
@@ -132,6 +137,10 @@
         return v8::String::New("array");
     if (V8HTMLCollection::HasInstance(value))
         return v8::String::New("array");
+    if (V8Int8Array::HasInstance(value) || V8Int16Array::HasInstance(value) || V8Int32Array::HasInstance(value))
+        return v8::String::New("array");
+    if (V8Float32Array::HasInstance(value) || V8Float64Array::HasInstance(value))
+        return v8::String::New("array");
     return v8::Undefined();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to