Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c210f6aba610272b3da3e48813257f160c55836f
https://github.com/WebKit/WebKit/commit/c210f6aba610272b3da3e48813257f160c55836f
Author: Timothy Hatcher <timo...@apple.com>
Date: 2024-02-26 (Mon, 26 Feb 2024)
Changed paths:
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
Log Message:
-----------
Tapping locked 1Password icon in password field fails to open popup.
https://webkit.org/b/270116
rdar://123647578
Reviewed by Brian Weinstein.
1Password calls the browser.openPopup() function when the extension is locked.
This is failing
due to them not telling us what window or tab to use, instead they are relying
on us using the
active window and tab. Currently we use the default action, which has no tab
associated and
this causes Safari to fail to present the popup.
Always use the tab's action when handling browser.openPopup() with a windowID,
or no arguments
(implying the frontmost window and active tab).
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm:
(WebKit::WebExtensionContext::actionOpenPopup): Combine paths, so there is one
final call to
the performAction method which will always have an associated tab.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST): Updated expected results for associatedTab.
Canonical link: https://commits.webkit.org/275346@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
