Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a1b2c8aedf261c714415790469da38d3dee7f38 https://github.com/WebKit/WebKit/commit/4a1b2c8aedf261c714415790469da38d3dee7f38 Author: Vitaly Dyachkov <vit...@igalia.com> Date: 2024-03-07 (Thu, 07 Mar 2024)
Changed paths: M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp Log Message: ----------- [GTK][Debug] ASSERTs on inspector tests https://bugs.webkit.org/show_bug.cgi?id=270447 Reviewed by Carlos Garcia Campos. `InspectorTimelineAgent` uses a stack to store timeline records and expects `pushCurrentRecord()`/`didCompleteCurrentRecord()` to be called in the correct order. But since frame rendering occurs more frequently than compositing, associated records may be processed in the wrong order: - push `TimelineRecordType::RenderingFrame` - push `TimelineRecordType::Composite` - complete `TimelineRecordType::RenderingFrame` - complete `TimelineRecordType::Composite` To prevent this, we must explicitly call `didComposite()` before pushing a new `RenderingFrame` record, like it's done on Mac. * Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::internalStart): Canonical link: https://commits.webkit.org/275785@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes