Title: [110564] trunk/Source
- Revision
- 110564
- Author
- gav...@chromium.org
- Date
- 2012-03-13 08:18:42 -0700 (Tue, 13 Mar 2012)
Log Message
Make ApplicationCacheHost::canCacheInPageCache() non-const.
https://bugs.webkit.org/show_bug.cgi?id=80904
Reviewed by Alexey Proskuryakov.
A const pointer to a large object like ApplicationCacheHost is not our standard
practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898
Source/WebCore:
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):
* loader/appcache/ApplicationCacheHost.h:
(ApplicationCacheHost):
Source/WebKit/chromium:
* src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110563 => 110564)
--- trunk/Source/WebCore/ChangeLog 2012-03-13 15:14:57 UTC (rev 110563)
+++ trunk/Source/WebCore/ChangeLog 2012-03-13 15:18:42 UTC (rev 110564)
@@ -1,3 +1,18 @@
+2012-03-13 Gavin Peters <gav...@chromium.org>
+
+ Make ApplicationCacheHost::canCacheInPageCache() non-const.
+ https://bugs.webkit.org/show_bug.cgi?id=80904
+
+ Reviewed by Alexey Proskuryakov.
+
+ A const pointer to a large object like ApplicationCacheHost is not our standard
+ practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898
+
+ * loader/appcache/ApplicationCacheHost.cpp:
+ (WebCore::ApplicationCacheHost::canCacheInPageCache):
+ * loader/appcache/ApplicationCacheHost.h:
+ (ApplicationCacheHost):
+
2012-03-13 Stephen Chenney <schen...@chromium.org>
Crash in WebCore::GraphicsContext::paintingDisabled
Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp (110563 => 110564)
--- trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp 2012-03-13 15:14:57 UTC (rev 110563)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp 2012-03-13 15:18:42 UTC (rev 110564)
@@ -228,7 +228,7 @@
}
}
-bool ApplicationCacheHost::canCacheInPageCache() const
+bool ApplicationCacheHost::canCacheInPageCache()
{
return !applicationCache() && !candidateApplicationCacheGroup();
}
Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.h (110563 => 110564)
--- trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.h 2012-03-13 15:14:57 UTC (rev 110563)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.h 2012-03-13 15:18:42 UTC (rev 110564)
@@ -136,7 +136,7 @@
bool maybeLoadSynchronously(ResourceRequest&, ResourceError&, ResourceResponse&, Vector<char>& data);
void maybeLoadFallbackSynchronously(const ResourceRequest&, ResourceError&, ResourceResponse&, Vector<char>& data);
- bool canCacheInPageCache() const;
+ bool canCacheInPageCache();
Status status() const;
bool update();
Modified: trunk/Source/WebKit/chromium/ChangeLog (110563 => 110564)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-13 15:14:57 UTC (rev 110563)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-13 15:18:42 UTC (rev 110564)
@@ -1,3 +1,16 @@
+2012-03-13 Gavin Peters <gav...@chromium.org>
+
+ Make ApplicationCacheHost::canCacheInPageCache() non-const.
+ https://bugs.webkit.org/show_bug.cgi?id=80904
+
+ Reviewed by Alexey Proskuryakov.
+
+ A const pointer to a large object like ApplicationCacheHost is not our standard
+ practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898
+
+ * src/ApplicationCacheHost.cpp:
+ (WebCore::ApplicationCacheHost::canCacheInPageCache):
+
2012-03-13 Kinuko Yasuda <kin...@chromium.org>
Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths
Modified: trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp (110563 => 110564)
--- trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp 2012-03-13 15:14:57 UTC (rev 110563)
+++ trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp 2012-03-13 15:18:42 UTC (rev 110564)
@@ -193,7 +193,7 @@
// N/A to the chromium port
}
-bool ApplicationCacheHost::canCacheInPageCache() const
+bool ApplicationCacheHost::canCacheInPageCache()
{
// N/A to the chromium port which doesn't use the page cache.
return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
