Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82bbfe731a36c812693c8326286281b561b52377 https://github.com/WebKit/WebKit/commit/82bbfe731a36c812693c8326286281b561b52377 Author: Carlos Garcia Campos <cgar...@igalia.com> Date: 2024-03-21 (Thu, 21 Mar 2024)
Changed paths: M Source/WebCore/platform/graphics/FontCache.h M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp M Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp Log Message: ----------- [Skia] Create the font manager on demand when first needed https://bugs.webkit.org/show_bug.cgi?id=271396 Reviewed by Adrian Perez de Castro. We are creating the font manager in FontCache::platformInit(), but that's only called once for all the instances. This makes all offscreen canvas tests rendering text to crash, because the FontCache in the worker thread doesn't have a font manager. * Source/WebCore/platform/graphics/FontCache.h: (WebCore::FontCache::fontManager const): Deleted. * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::fontManager const): (WebCore::FontCache::systemFallbackForCharacterCluster): (WebCore::FontCache::systemFontFamilies): (WebCore::FontCache::createFontPlatformData): * Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp: (WebCore::FontCustomPlatformData::create): Canonical link: https://commits.webkit.org/276483@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes