Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46520106b8b99191f7af6b78883c380f883178f7 https://github.com/WebKit/WebKit/commit/46520106b8b99191f7af6b78883c380f883178f7 Author: Alex Christensen <achristen...@apple.com> Date: 2024-03-26 (Tue, 26 Mar 2024)
Changed paths: M LayoutTests/http/tests/site-isolation/notify-done-expected.txt M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp Log Message: ----------- Introduce RemoteFrame support for testRunner.dumpChildFramesAsText https://bugs.webkit.org/show_bug.cgi?id=271724 rdar://125437971 Reviewed by Charlie Wolfe. This is the first of at least two steps to get tests like http/tests/security/window-properties-pass.html passing with --site-isolation. If the frame text is not in the current process, send a message to the process that contains the frame to get its text. FrameTree::uniqueName is not hooked up correctly so the test output isn't identical yet, but this makes more than 0 output. The separate asDocumentElement test wasn't actually useful because it was redundant with the same test done in WebFrame::innerText, so it was removed. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::renderTreeAsTextForTesting): (WebKit::WebPageProxy::frameTextForTesting): (WebKit::WebPageProxy::renderTreeAsText): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameCopyInnerText): Deleted. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyFrameTextForTesting): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::renderTreeAsText): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::innerText const): (WebKit::WebFrame::frameTextForTesting): * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::frameTextForTestingIncludingSubframes): (WebKit::WebPage::renderTreeAsTextForTesting): (WebKit::WebPage::frameTextForTesting): (WebKit::WebPage::renderTreeAsText): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dumpAllFramesText): (WTR::InjectedBundlePage::dump): (WTR::hasDocumentElement): Deleted. (WTR::dumpFrameText): Deleted. (WTR::dumpDescendantFramesText): Deleted. Canonical link: https://commits.webkit.org/276723@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes