Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 50bd98ed095eed2950642d5a83b687e2a377484f
https://github.com/WebKit/WebKit/commit/50bd98ed095eed2950642d5a83b687e2a377484f
Author: Alan Baradlay <[email protected]>
Date: 2024-03-28 (Thu, 28 Mar 2024)
Changed paths:
A
LayoutTests/fast/text/minimum-width-with-break-all-and-whitespace-only-expected.html
A
LayoutTests/fast/text/minimum-width-with-break-all-and-whitespace-only.html
M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp
Log Message:
-----------
ASSERTION FAILED: contentHasNegativeImplicitMargin on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=271815
<rdar://125373960>
Reviewed by Antti Koivisto.
Simplified (non-line-builder based) minimum content width logic fails to
ignore collapsed whitespace. In case of whitespace content only (e.g.
<div><span> </span></div>)
we end up computing a minimum width value as if the whitespace was preserved
-which could produce
a larger min-width value than max-width -> ASSERT.
(Note that this only affects content where arbitrary breaking position is
enabled e.g. word-break: break-word)
*
LayoutTests/fast/text/minimum-width-with-break-all-and-whitespace-only-expected.html:
Added.
* LayoutTests/fast/text/minimum-width-with-break-all-and-whitespace-only.html:
Added.
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::simplifiedMinimumWidth const):
Canonical link: https://commits.webkit.org/276774@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
