Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a64b0eff0e3cfa58863523af72f27a902fad7e4 https://github.com/WebKit/WebKit/commit/2a64b0eff0e3cfa58863523af72f27a902fad7e4 Author: Karl Dubost <karl...@apple.com> Date: 2024-04-04 (Thu, 04 Apr 2024)
Changed paths: M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py Log Message: ----------- Web Inspector: Generating JS builtins for createInspectorInjectedScript is very slow https://bugs.webkit.org/show_bug.cgi?id=271610 rdar://125703146 Reviewed by Justin Michaud. This patch puts guard to run certain regex.search() commands to execute them only when necessary. It also get rid of RegexPattern.sub() which is very costly on long files, and replaces it by str.replace(pattern, '') I checked that the same files where generated without diff with the current main code. JSCBuiltins.cpp JSCBuiltins.h This patch reduces the execution time of python Source/JavaScriptCore/Scripts/generate-js-builtins.py --framework JavaScriptCore --output-directory /tmp/ --combined Source/JavaScriptCore/builtins/*.js Source/JavaScriptCore/inspector/InjectedScriptSource.js from ~21s to 0.1s That should make the build bots happier. * Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py: (BuiltinFunction.fromString): Canonical link: https://commits.webkit.org/277085@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes