Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e624ea204dd94f6d49d7d788f51ae17bd2d419d https://github.com/WebKit/WebKit/commit/6e624ea204dd94f6d49d7d788f51ae17bd2d419d Author: Darin Adler <da...@apple.com> Date: 2024-04-07 (Sun, 07 Apr 2024)
Changed paths: M Source/JavaScriptCore/runtime/ConfigFile.cpp M Source/JavaScriptCore/runtime/IntlNumberFormatInlines.h M Source/JavaScriptCore/runtime/LiteralParser.cpp M Source/JavaScriptCore/tools/FunctionOverrides.cpp M Source/WTF/wtf/text/StringBuilder.cpp M Source/WTF/wtf/text/StringBuilder.h M Source/WebCore/PAL/pal/text/TextCodecICU.cpp M Source/WebCore/editing/MarkupAccumulator.cpp M Source/WebCore/platform/text/SegmentedString.cpp M Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp Log Message: ----------- Remove StringBuilder::appendCharacters, use std::span more https://bugs.webkit.org/show_bug.cgi?id=272284 rdar://problem/126026642 Reviewed by Chris Dumez. No need for a separate name appendCharacters now that we can append a run of characters with a single argument, a span. * Source/JavaScriptCore/runtime/ConfigFile.cpp: (JSC::ConfigFile::parse): Use append(span) instead of appendCharacters(pointer, length). * Source/JavaScriptCore/runtime/IntlNumberFormatInlines.h: (JSC::appendNumberFormatDigitOptionsToSkeleton): Ditto. * Source/JavaScriptCore/runtime/LiteralParser.cpp: (JSC::LiteralParser<CharType>::Lexer::lexStringSlow): Ditto. * Source/JavaScriptCore/tools/FunctionOverrides.cpp: (JSC::parseClause): Ditto. * Source/WTF/wtf/text/StringBuilder.cpp: (WTF::StringBuilder::append): Renamed from appendCharacters. * Source/WTF/wtf/text/StringBuilder.h: Renamed appendCharacters to append, deleted the overloads that took a separate pointer and length. Updated all the callers in the inline functions. * Source/WebCore/PAL/pal/text/TextCodecICU.cpp: (PAL::TextCodecICU::decode): Use append(span) instead of appendCharacters(pointer, length). * Source/WebCore/editing/MarkupAccumulator.cpp: (WebCore::appendCharactersReplacingEntitiesInternal): Use append(ASCIILiteral) instead of appendCharacters(pointer, length) * Source/WebCore/platform/text/SegmentedString.cpp: (WebCore::SegmentedString::Substring::appendTo const): Use append(span) instead of appendCharacters(pointer, length). * Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp: (TestWebKitAPI::TEST(StringBuilderTest, Append)): Ditto. (TestWebKitAPI::TEST(StringBuilderTest, ToAtomStringOnEmpty)): Ditto. Canonical link: https://commits.webkit.org/277176@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes