Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4c17927610b9ae436eb76bd1dea3354921331c35
https://github.com/WebKit/WebKit/commit/4c17927610b9ae436eb76bd1dea3354921331c35
Author: Rob Buis <[email protected]>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
A LayoutTests/fast/forms/form-submission-crash-4-expected.txt
A LayoutTests/fast/forms/form-submission-crash-4.html
M Source/WebCore/loader/FormState.cpp
Log Message:
-----------
Update RELEASE_ASSERT in FormState::willDetachPage
https://bugs.webkit.org/show_bug.cgi?id=270479
rdar://123991819
Reviewed by Chris Dumez.
During the call to continueLoadAfterNavigationPolicy(), it's possible for the
frame to be detached. The
FrameDestructionObserver willDetachPage() implementation in FormState has the
expectation that there
is only one reference at this stage, so having an extra one during the scope of
continueLoadAfterNavigationPolicy() might break this assumption.
To respect the new smart pointer adoption guidelines, but also keep the trap
introduced in
https://trac.webkit.org/changeset/229683/webkit, use refCount() instead.
* LayoutTests/fast/forms/form-submission-crash-4-expected.txt: Added.
* LayoutTests/fast/forms/form-submission-crash-4.html: Added.
* Source/WebCore/loader/FormState.cpp:
(WebCore::FormState::willDetachPage):
Canonical link: https://commits.webkit.org/277207@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
