Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef7c999e5c101b9113bb61a3002942f86f99f089
      
https://github.com/WebKit/WebKit/commit/ef7c999e5c101b9113bb61a3002942f86f99f089
  Author: Wenson Hsieh <wenson_hs...@apple.com>
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
    M 
LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html
    M LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html

  Log Message:
  -----------
  [iOS] fast/writing-mode/english-bt-text-with-spelling-marker.html is a flaky 
failure after 277233@main
https://bugs.webkit.org/show_bug.cgi?id=272395

Reviewed by Aditya Keerthi.

After the changes in 277233@main, spelling dots are now showing up on iOS, in 
this test; this causes
a very slight image diff, as the direction of the gradient differs slightly 
between the reference
and test.

Fix this by adjusting the `maxDifference` to accommodate iOS 17, and also 
adjust the test itself to
reliably show spelling dots by adding `spellCheckingDots=true` as a test 
option, and also use
`UIHelper.setSpellCheckerResults` to force spellchecking to detect 
`"mispelled"` as a misspelled
word.

* 
LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
* LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:

Canonical link: https://commits.webkit.org/277254@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to