Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30130d3b5da29c0f75b942c0ecf2c1430151fbf2
      
https://github.com/WebKit/WebKit/commit/30130d3b5da29c0f75b942c0ecf2c1430151fbf2
  Author: Alan Baradlay <za...@apple.com>
  Date:   2024-04-13 (Sat, 13 Apr 2024)

  Changed paths:
    A 
LayoutTests/fast/text/missing-content-in-tight-space-with-float-expected.html
    A LayoutTests/fast/text/missing-content-in-tight-space-with-float.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  Break-word with a float can discard text
https://bugs.webkit.org/show_bug.cgi?id=272534
<rdar://problem/126309547>

Reviewed by Antti Koivisto.

1. a suspended float gets placed on the current line (a float that we couldn't 
place while processing the previous line)
2. due to tight space and arbitrary breaking position, only partial content 
gets placed next to the float (e.g. [arbitrary] -> [arb][itrary] -where only 
the first part gets placed)

In such cases we incorrectly compute the end of the "laid out" inline item 
range.
This incorrectly computed range points to the end of inline item ([arbitrary]) 
as opposed to
somewhere in the middle ([arb]) which makes us think the next line starts 
_after_ [arbitrary].

* 
LayoutTests/fast/text/missing-content-in-tight-space-with-float-expected.html: 
Added.
* LayoutTests/fast/text/missing-content-in-tight-space-with-float.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):

Canonical link: https://commits.webkit.org/277461@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to