Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e530f8ef12baeb5fa5cc60e2e44122a7445f1a3b
https://github.com/WebKit/WebKit/commit/e530f8ef12baeb5fa5cc60e2e44122a7445f1a3b
Author: Brianna Fan <bf...@apple.com>
Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
find-modified-layout-tests step should detect the tests modified in test
expectations in a PR
https://bugs.webkit.org/show_bug.cgi?id=271721
rdar://problem/123398588
Reviewed by Jonathan Bedard.
Add additional steps to check if TestExpectations is modified.
These save the output of run-webkit-tests --print-expectations before and after
the PR/patch is applied.
Then these two results are compared to get any changes to test expectations.
* Tools/CISupport/ews-build/factories.py:
(Factory): Add skipBuildIfNoResult property.
(Factory.__init__): Add GetTestExpectationsBaseline() and
GetUpdatedTestExpectations(). Move FindModifiedLayoutTests().
(TestFactory): Set skipBuildIfNoResult.
(iOSTestsFactory): Set findModifiedLayoutTests.
(macOSWK1Factory): Ditto.
(macOSWK2Factory): Ditto.
(GTKTestsFactory): Ditto.
(WPETestsFactory): Ditto.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(GetTestExpectationsBaseline): Print test expectations before applying changes.
(GetTestExpectationsBaseline.run):
(GetUpdatedTestExpectations): Print test expectations again after applying
changes.
(GetUpdatedTestExpectations.run):
(FindModifiedLayoutTests): Parse diff between two expectations and check patch
for LayoutTest changes.
(FindModifiedLayoutTests.run):
(FindModifiedLayoutTests.getResultSummary):
(FindModifiedLayoutTests.start): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestGetTestExpectationsBaseline): Added.
(TestGetUpdatedTestExpectations): Added.
(TestFindModifiedLayoutTests):
(TestFindModifiedLayoutTests.test_non_accessible_patch): Test for
non-accessible patch/PR contents.
Canonical link: https://commits.webkit.org/277546@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
