Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a65c65a9ee61610307216fd8dda89d6ff89b441e https://github.com/WebKit/WebKit/commit/a65c65a9ee61610307216fd8dda89d6ff89b441e Author: Wenson Hsieh <wenson_hs...@apple.com> Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths: A LayoutTests/fast/element-targeting/target-iframe-above-nav-bar-expected.txt A LayoutTests/fast/element-targeting/target-iframe-above-nav-bar.html M Source/WebCore/page/ElementTargetingController.cpp Log Message: ----------- [Remote Inspection] Make it easier to inspect only iframes with nearby navigational elements https://bugs.webkit.org/show_bug.cgi?id=272765 rdar://123279263 Reviewed by Megan Gardner. Adjust the targeting heuristic to make it easier to inspect `iframe`s without targeting enclosing container elements that contain navigational elements (e.g. nav bars). If needed, we can expand this "narrowing heuristic" to care about more than just navigational elements. * LayoutTests/fast/element-targeting/target-iframe-above-nav-bar-expected.txt: Added. * LayoutTests/fast/element-targeting/target-iframe-above-nav-bar.html: Added. * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::isNavigationalElement): (WebCore::containsNavigationalElement): (WebCore::isTargetCandidate): (WebCore::ElementTargetingController::findTargets): Canonical link: https://commits.webkit.org/277578@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes