Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4e89f8e7470c9dd85838a7ab49adfcdeb805772b
https://github.com/WebKit/WebKit/commit/4e89f8e7470c9dd85838a7ab49adfcdeb805772b
Author: Abrar Rahman Protyasha <a_protya...@apple.com>
Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
[UnifiedPDF] Data detector overlay gets detached from document when pinching
out
https://bugs.webkit.org/show_bug.cgi?id=272715
rdar://126514405
Reviewed by Aditya Keerthi.
Currently, data detector overlay rects are only invalidated via
UnifiedPDFPlugin::didChangeScrollOffset, so any updates due to zooming
in/out are coincidental. When pinching out far enough, there is no more
change in scroll position, and thus the overlay rects are never
invalidated.
This patch fixes the issue by ensuring we call
PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects
whenever the scale factor changes, matching prior art from 277438@main.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::didInvalidateDataDetectorHighlightOverlayRects):
We introduce this reusable helper to keep the update codepaths DRY.
(WebKit::UnifiedPDFPlugin::setScaleFactor):
(WebKit::UnifiedPDFPlugin::didChangeScrollOffset):
Canonical link: https://commits.webkit.org/277583@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
