Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63355e0745267f9891ebe07dc1f3aa96e59eb707 https://github.com/WebKit/WebKit/commit/63355e0745267f9891ebe07dc1f3aa96e59eb707 Author: Timothy Hatcher <timo...@apple.com> Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths: M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionController.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm Log Message: ----------- declarativeNetRequest redirect and modifyHeaders rules don't work. https://webkit.org/b/272763 rdar://problem/126562335 Reviewed by Brian Weinstein. We were not setting activeContentRuleListActionPatterns() for the network process to check if the extension had permissions to modify the requests, since the rules require declarativeNetRequestWithHostAccess and granted host permission patterns. * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): Added call to extension controller. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::resourceDataForPath): Add support for any JSON. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::updateWebsitePoliciesForNavigation): Added. Set activeContentRuleListActionPatterns for each extension context that has declarativeNetRequestWithHostAccess permissions. * Source/WebKit/UIProcess/Extensions/WebExtensionController.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm: (TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, DISABLED_RedirectRule)): Added. Blocked on fixing rdar://116459903 (Web Process is crashing when using declarativeNetRequest to redirect a page). (TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, RedirectRuleWithoutHostAccessPermission)): Added. (TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, RedirectRuleWithoutHostPermission)): Added. (TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, ModifyHeadersRule)): Added. (TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, ModifyHeadersRuleWithoutHostAccessPermission)): Added. (TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, ModifyHeadersRuleWithoutHostPermission)): Added. Canonical link: https://commits.webkit.org/277681@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes