Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a09b94a65009978eb3e5f4417b46f8687c834564 https://github.com/WebKit/WebKit/commit/a09b94a65009978eb3e5f4417b46f8687c834564 Author: Patrick Griffis <pgrif...@igalia.com> Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-base-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-gc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-src-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-replace-same-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-rejection-order-detached-unserializablestate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-unserializable-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/same-document-away-and-back-location-api-expected.txt M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/bindings/js/JSDOMPromiseDeferred.h M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: ----------- [Navigation] Track in-progress navigations https://bugs.webkit.org/show_bug.cgi?id=272459 Reviewed by Alex Christensen. This makes use of the NavigationAPITracker to correctly complete the Navigation::Result when events happen. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-noop-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-base-url-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-gc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-from-initial-about-blank-src-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-replace-same-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-already-detached-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-detach-in-serialization-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-already-detached-expected.txt: * Source/WebCore/bindings/js/JSDOMPromiseDeferred.h: (WebCore::callPromisePairFunction): The JSPromise needs to not be cleared because we create a DOMPromise with it later. * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::createDOMPromise): (WebCore::Navigation::createErrorResult): (WebCore::Navigation::maybeSetUpcomingNonTraversalTracker): (WebCore::Navigation::addUpcomingTrarveseAPIMethodTracker): (WebCore::Navigation::apiMethodTrackerDerivedResult): (WebCore::Navigation::reload): (WebCore::Navigation::navigate): (WebCore::Navigation::performTraversal): (WebCore::Navigation::traverseTo): (WebCore::Navigation::back): (WebCore::Navigation::forward): (WebCore::Navigation::updateCurrentEntry): (WebCore::Navigation::hasEntriesAndEventsDisabled const): (WebCore::Navigation::resolveFinishedPromise): (WebCore::notifyCommittedToEntry): (WebCore::Navigation::updateForNavigation): (WebCore::Navigation::promoteUpcomingAPIMethodTracker): (WebCore::Navigation::cleanupAPIMethodTracker): (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::createErrorResult): Deleted. * Source/WebCore/page/Navigation.h: (WebCore::NavigationAPIMethodTracker::NavigationAPIMethodTracker): Canonical link: https://commits.webkit.org/277688@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes