Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6168be34e9eaad0af1a25c6e09e35cb11896d567
https://github.com/WebKit/WebKit/commit/6168be34e9eaad0af1a25c6e09e35cb11896d567
Author: Tyler Wilcock <[email protected]>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt
M LayoutTests/accessibility/aria-labelledby-on-password-input.html
M
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt
M
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Log Message:
-----------
AX: AccessibilityNodeObject::labelText adds empty accessibility text if the
object has a title UI element
https://bugs.webkit.org/show_bug.cgi?id=272947
rdar://126725780
Reviewed by Chris Fleizach.
When this code was added 12 years ago in
https://github.com/WebKit/WebKit/commit/df8d39165ed615be913a454c22d718265c5be483,
it included the titleUIElement in the AccessibilityText entry alongside the
empty string so that it could extract the
text from the element when necessary. However, the field that stored the
titleUIElement in AccessibilityText has since
been removed, so this no longer makes sense.
This behavior causes a WPT failure, as AccessibilityObject::computedLabel()
exposes the first entry in the result
of AXCoreObject::accessibilityText, which was this empty string in the case of
a fieldset labeled by a legend. The
second entry is the correct text, so removing this empty string allows us to
pass the test.
* LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt:
* LayoutTests/accessibility/aria-labelledby-on-password-input.html:
*
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt:
*
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::labelText const):
Canonical link: https://commits.webkit.org/277739@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
