Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0de43f2ad98a839ab622d10b37e3f4287d5af70a
https://github.com/WebKit/WebKit/commit/0de43f2ad98a839ab622d10b37e3f4287d5af70a
Author: Sam Sneddon <[email protected]>
Date: 2024-04-19 (Fri, 19 Apr 2024)
Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/device_port.py
M Tools/Scripts/webkitpy/port/ios_device_unittest.py
Log Message:
-----------
Skipped-by-default ignored for second-and-later device_types
https://bugs.webkit.org/show_bug.cgi?id=271716
Reviewed by Jonathan Bedard.
The intention of 267745@main was to limit the number of simulators we're
using for all devices besides the first.
However, it inadvertently led to us never skipping those devices when
Port.default_child_processes() is zero and Port.max_child_processes() is
not, and made it harder to reason about what we're doing in this already
gnarly loop (not helped by the comment being incorrect: this doesn't
affect retries).
Instead, let's track if we're running against a simulator, and if so
explicitly limit the max child processes to one for devices besides
the first, which was the intention of that change.
While we're at it, make the logging account for the possibility of a
device that isn't run by default.
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
* Tools/Scripts/webkitpy/port/base.py:
(Port.is_simulator):
* Tools/Scripts/webkitpy/port/device_port.py:
(DevicePort.is_simulator):
(DevicePort.max_child_processes):
(DevicePort.supported_device_types):
(DevicePort.configuration_for_upload):
* Tools/Scripts/webkitpy/port/ios_device_unittest.py:
(IOSDeviceTest.make_port):
Canonical link: https://commits.webkit.org/277755@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
