Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 47229755a5e79561361ae8c827edd448c5f2bff3
https://github.com/WebKit/WebKit/commit/47229755a5e79561361ae8c827edd448c5f2bff3
Author: Sihui Liu <[email protected]>
Date: 2024-04-22 (Mon, 22 Apr 2024)
Changed paths:
A
LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site-expected.txt
A
LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site.html
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
Log Message:
-----------
[Site Isolation] Make LocalDOMWindow::createWindow return Frame
https://bugs.webkit.org/show_bug.cgi?id=272995
rdar://problem/126759468
Reviewed by Alex Christensen and Pascoe.
Currently LocalDOMWindow::createWindow only returns `LocalFrame`, but
`findFrameForNavigation` (invoked in
WebCore::createWindow) can return a `RemoteFrame` for window with target name.
See new test for an example. To fix that,
make LocalDOMWindow::createWindow return Frame.
Test: http/tests/site-isolation/window-open-with-name-cross-site.html
*
LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site-expected.txt:
Added.
* LayoutTests/http/tests/site-isolation/window-open-with-name-cross-site.html:
Added.
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::createWindow):
* Source/WebCore/page/LocalDOMWindow.h:
Canonical link: https://commits.webkit.org/277829@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
