Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 235ae8a090b2798b982fa2737c5df7d65d26298b
https://github.com/WebKit/WebKit/commit/235ae8a090b2798b982fa2737c5df7d65d26298b
Author: Antti Koivisto <[email protected]>
Date: 2024-04-23 (Tue, 23 Apr 2024)
Changed paths:
M
LayoutTests/fast/block/positioning/fixed-container-with-relative-parent-expected.html
A
LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild-expected.html
A LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild.html
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleUpdate.cpp
M Source/WebCore/style/StyleUpdate.h
Log Message:
-----------
Rebuild continuations when position property changes
https://bugs.webkit.org/show_bug.cgi?id=273137
rdar://124987637
Reviewed by Alan Baradlay.
We fail to clear continuation renderers when a renderer becomes out-of-flow
positioned.
In some cases this has painting or layout effects.
*
LayoutTests/fast/block/positioning/fixed-container-with-relative-parent-expected.html:
Expectations of this tests were wrong and didn't match other browsers. Simply
compare against the non-dynamic case.
*
LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild-expected.html:
Added.
* LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild.html:
Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRebuildRoots):
Check if the rebuild root is inside a continuation. If so start the rebuild
from the ancestor.
Also copy pseudo-elements.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
If position property changes we need to check for different rebuild root.
* Source/WebCore/style/StyleUpdate.cpp:
(WebCore::Style::Update::addElement):
Collect potential rebuild roots based on a bit in Style::Update.
* Source/WebCore/style/StyleUpdate.h:
Canonical link: https://commits.webkit.org/277912@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
