Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71bd202cfeb44ab86897267afd37bd7bda0cb17a
https://github.com/WebKit/WebKit/commit/71bd202cfeb44ab86897267afd37bd7bda0cb17a
Author: Kimmo Kinnunen <[email protected]>
Date: 2024-04-25 (Thu, 25 Apr 2024)
Changed paths:
A
LayoutTests/fast/webgpu/copy-texture-to-texture-astc-mipmap-dimensions-crash-expected.txt
A
LayoutTests/fast/webgpu/copy-texture-to-texture-astc-mipmap-dimensions-crash.html
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm
Log Message:
-----------
ASSERT while clearing ASTC textures for copy
https://bugs.webkit.org/show_bug.cgi?id=273099
rdar://126894196
Reviewed by Mike Wyrzykowski.
Textures would be cleared with blit from empty texture. The blit size
would be calculated from logical texture size. This is incorrect for
cases where compressed texture mipmap levels != 1 would be used, since
their logical sizes might not be block aligned. The physical sizes
would need to be used.
Use correct function WTF::roundUpToMultipleOfNonPowerOfTwo().
*
LayoutTests/fast/webgpu/copy-texture-to-texture-astc-mipmap-dimensions-crash-expected.txt:
Added.
*
LayoutTests/fast/webgpu/copy-texture-to-texture-astc-mipmap-dimensions-crash.html:
Added.
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::clearTextureIfNeeded):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::bytesPerRow):
(WebGPU::Texture::physicalMiplevelSpecificTextureExtent):
(WebGPU::Texture::physicalTextureExtent):
Canonical link: https://commits.webkit.org/278006@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
