Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1dd6d95b8d0042314e0317594c2341ab5cac55b6 https://github.com/WebKit/WebKit/commit/1dd6d95b8d0042314e0317594c2341ab5cac55b6 Author: Tyler Wilcock <tyle...@apple.com> Date: 2024-04-27 (Sat, 27 Apr 2024)
Changed paths: A LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-line-expected.txt A LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-line.html A LayoutTests/accessibility/mac/text-marker-range-for-line-expected.txt A LayoutTests/accessibility/mac/text-marker-range-for-line.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/accessibility/AXTextMarker.cpp M Source/WebCore/accessibility/AXTextMarker.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: ----------- AX: Implement off-main-thread support for AXTextMarkerRangeForLineAttribute https://bugs.webkit.org/show_bug.cgi?id=273248 rdar://problem/127052882 Reviewed by Chris Fleizach. No tests existed for this attribute, so this patch adds one, including the AccessibilityUIElement testing infrastructure to do so. This patch also refactors test-only parameterized attributes into a new parameterizedAttributeValueForTesting, as this patch benefited from adding a new one (AXTextMarkerRangeIsValid). * LayoutTests/accessibility-isolated-tree/TestExpectations: * LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-line-expected.txt: Added. * LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-line.html: Added. * LayoutTests/accessibility/mac/text-marker-range-for-line-expected.txt: Added. * LayoutTests/accessibility/mac/text-marker-range-for-line.html: Added. * Source/WebCore/accessibility/AXTextMarker.cpp: (WebCore::AXTextMarker::characterRangeForLine const): (WebCore::AXTextMarker::markerRangeForLine const): (WebCore::AXTextMarker::rangeForLine const): Deleted. * Source/WebCore/accessibility/AXTextMarker.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::doAXRangeForLine const): * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h: * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (parameterizedAttributeValueForTesting): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::isTextMarkerRangeValid): (WTR::AccessibilityUIElement::textMarkerRangeForLine): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::textMarkerRangeForLine): (WTR::AccessibilityUIElement::isTextMarkerRangeValid): Canonical link: https://commits.webkit.org/278081@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes