Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aaecbac76dbf8704715a9859be1852db13c34817
      
https://github.com/WebKit/WebKit/commit/aaecbac76dbf8704715a9859be1852db13c34817
  Author: Darin Adler <da...@apple.com>
  Date:   2024-04-28 (Sun, 28 Apr 2024)

  Changed paths:
    A 
LayoutTests/fast/css/view-transitions-nested-transparency-layers-expected.html
    A LayoutTests/fast/css/view-transitions-nested-transparency-layers.html
    A 
LayoutTests/fast/css/view-transitions-unbalanced-transparency-layers-assertion-expected.txt
    A 
LayoutTests/fast/css/view-transitions-unbalanced-transparency-layers-assertion.html
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h

  Log Message:
  -----------
  [view-transitions] Assertion due to unbalanced begin/end transparency layers
https://bugs.webkit.org/show_bug.cgi?id=273377
rdar://126279004

Reviewed by Matt Woodrow.

Transparency layers were being applied for render layers that we are not 
painting.

* 
LayoutTests/fast/css/view-transitions-nested-transparency-layers-expected.html: 
Added.
* LayoutTests/fast/css/view-transitions-nested-transparency-layers.html: Added.
* 
LayoutTests/fast/css/view-transitions-unbalanced-transparency-layers-assertion-expected.txt:
 Added.
* 
LayoutTests/fast/css/view-transitions-unbalanced-transparency-layers-assertion.html:
 Added.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::transparentPaintingAncestor): Stop at root layer.
(WebCore::RenderLayer::beginTransparencyLayers): Pass LayerPaintingInfo in to 
transparentPaintingAncestor.
(WebCore::RenderLayer::paintLayerWithEffects): Stop at root layer.
* Source/WebCore/rendering/RenderLayer.h: Change private 
beginTransparencyLayers function to
take LayerPaintingInfo argument.

Canonical link: https://commits.webkit.org/278096@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to