Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 4821777778e82fcf78116a4e0e744c38f20ad661 https://github.com/WebKit/WebKit/commit/4821777778e82fcf78116a4e0e744c38f20ad661 Author: Michael Catanzaro <mcatanz...@redhat.com> Date: 2024-05-09 (Thu, 09 May 2024)
Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp Log Message: ----------- Cherry-pick 278456@main (48d82b12d119). https://bugs.webkit.org/show_bug.cgi?id=273780 [GTK] Consider keycode when activating application accelerators https://bugs.webkit.org/show_bug.cgi?id=273780 Reviewed by Carlos Garcia Campos. Since Epiphany 46, keyboard shortcuts no longer work when using non-Latin keyboard layouts, like Ukranian or Hebrew. Currently we only consider the keyval when activating application accelerators. We need to consider the raw keycode as well. E.g. on a Hebrew keyboard pressing Ctrl+א should open a new tab, because the same key is used for both א and T. Fortunately, GTK can do the hard work of deciding which accelerator to activate for us. All we need to do is pass along the keycode. (This bug was *sort of* a regression from 273922@main. In practice, the regression probably only affected Epiphany, because this codepath only matters if the application allows the web view to process key events before it allows its GtkWindow to do so. That has to be done manually. Otherwise, this code will never be reached, because the GtkWindow would have already determined the key event matches an accelerator and handled it before the web view ever gets a chance to see it.) * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseProcessAcceleratorsForKeyPressEvent): Canonical link: https://commits.webkit.org/278456@main Canonical link: https://commits.webkit.org/274313.209@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes