Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7ee2bbe31b7ff81eb609d85ae5030cd12fcd4514
https://github.com/WebKit/WebKit/commit/7ee2bbe31b7ff81eb609d85ae5030cd12fcd4514
Author: Wenson Hsieh <wenson_hs...@apple.com>
Date: 2024-05-11 (Sat, 11 May 2024)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm
Log Message:
-----------
REGRESSION (268971@main): [ iOS ]
TestWebKitAPI.iOSMouseSupport.MouseDidMoveOverElement is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=273839
rdar://127691561
Reviewed by Megan Gardner and Richard Robinson.
The changes to `MouseEventTestHarness` in 268971@main made this API test time
out, but only on iPad.
That's because UIKit adds its own `UIHoverGestureRecognizer` subclasses to
`WKContentView` on iPad,
which causes the logic in the constructor of `MouseEventTestHarness` to
initialize
`m_hoverGestureRecognizer` to the wrong gesture. Subsequently, attempts to
simulate mouse movement
using this gesture recognizer fails to call into `WKMouseInteraction` delegate
methods.
To fix this, simply adjust this logic to check the name of the gesture
recognizer (`"WKMouseHover"`)
instead of relying on the class and `allowedTouchTypes`.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(TestWebKitAPI::MouseEventTestHarness::MouseEventTestHarness):
Canonical link: https://commits.webkit.org/278651@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
