Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d5ae59db1cbc2bcc2fd74d11dce31f9a8c86ef8
https://github.com/WebKit/WebKit/commit/5d5ae59db1cbc2bcc2fd74d11dce31f9a8c86ef8
Author: Simon Fraser <simon.fra...@apple.com>
Date: 2024-05-14 (Tue, 14 May 2024)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
[UnifiedPDF] Describe selection rects in terms of PDFPageCoverage
https://bugs.webkit.org/show_bug.cgi?id=274139
rdar://128043619
Reviewed by Abrar Rahman Protyasha.
Replace `UnifiedPDFPlugin::boundsForSelection()` with
`UnifiedPDFPlugin::pageCoverageForSelection()`
which returns a `PDFPageCoverage`, which will be useful in future when we need
to have per-page
selection bounds info.
`UnifiedPDFPlugin::textIndicatorForSelection()` can use this, asking for only
the first page.
`UnifiedPDFPlugin::selectionBoundsForFirstPageInDocumentSpace()` can be removed.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::pageCoverageForSelection const):
(WebKit::UnifiedPDFPlugin::boundsForSelection const):
(WebKit::UnifiedPDFPlugin::repaintOnSelectionActiveStateChangeIfNeeded):
(WebKit::UnifiedPDFPlugin::setCurrentSelection):
(WebKit::UnifiedPDFPlugin::textIndicatorForSelection):
(WebKit::UnifiedPDFPlugin::selectionBoundsForFirstPageInDocumentSpace const):
Deleted.
Canonical link: https://commits.webkit.org/278759@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
