Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f6eb17ce35389deafb0be3cedfa5f9d0308ee94 https://github.com/WebKit/WebKit/commit/6f6eb17ce35389deafb0be3cedfa5f9d0308ee94 Author: Mike Wyrzykowski <mwyrzykow...@apple.com> Date: 2024-05-20 (Mon, 20 May 2024)
Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: ----------- Interactionless USDZ Popups in Vision Pro <radar://122802255> Reviewed by Tim Horton. Show a pop-up asking the user to confirm they want to quick look preview a USDZ file in WebKit. Add a delay if the page constantly tries to open one such file otherwise it can be difficult to exit out of the page. * Source/WebCore/en.lproj/Localizable.strings: * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): Originally-landed-as: 272448.672@safari-7618-branch (6b6d3d3e61f6). rdar://128090184 Canonical link: https://commits.webkit.org/278998@main Commit: f1cfd5a3139a0e18dcf0279802c0867174696beb https://github.com/WebKit/WebKit/commit/f1cfd5a3139a0e18dcf0279802c0867174696beb Author: Mike Wyrzykowski <mwyrzykow...@apple.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm Log Message: ----------- Potential UAF in SystemPreviewController::begin https://bugs.webkit.org/show_bug.cgi?id=272342 radar://124988039 Reviewed by Aditya Keerthi. SystemPreviewController::begin was calling functions asychronously but directly using both an Objective-C object and a C++ object without checking to see if their lifetime's expired. This code also used the name 'protectedThis' to refer to a raw C++ pointer which seems a little confusing, so just drop the protectedThis and use this directly after ensuring the object has not been destructed based on the result of WeakPtr::get(). * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Originally-landed-as: 272448.892@safari-7618-branch (b53cc7cedea8). rdar://128279820 Canonical link: https://commits.webkit.org/278999@main Commit: b35f3f7eba94a42a8108ea651f1de8ea4a906402 https://github.com/WebKit/WebKit/commit/b35f3f7eba94a42a8108ea651f1de8ea4a906402 Author: Mike Wyrzykowski <mwyrzykow...@apple.com> Date: 2024-05-20 (Mon, 20 May 2024) Changed paths: M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm Log Message: ----------- Remove processing user gesture check before displaying prompt for usdz https://bugs.webkit.org/show_bug.cgi?id=272321 radar://126078233 Reviewed by Alexey Proskuryakov. Opening a usdz blob isn't considered to be processing a user gesture, so having the UserGestureIndicator::processingUserGesture() check results in the download path being taken instead of the prompt and open to ARQL. Since we already have the prompt, we can remove the user gesture check. * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): Originally-landed-as: 272448.918@safari-7618-branch (fe35964ae2b9). rdar://128280210 Canonical link: https://commits.webkit.org/279000@main Compare: https://github.com/WebKit/WebKit/compare/21e320d6fce2...b35f3f7eba94 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes