Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3948fcf9266c852214028357c1cad683ae06114 https://github.com/WebKit/WebKit/commit/e3948fcf9266c852214028357c1cad683ae06114 Author: Ryosuke Niwa <rn...@webkit.org> Date: 2024-05-21 (Tue, 21 May 2024)
Changed paths: M Source/WTF/wtf/Compiler.h M Source/WTF/wtf/JSONValues.h M Source/WTF/wtf/text/AtomStringImpl.cpp M Source/WTF/wtf/text/AtomStringImpl.h M Source/WTF/wtf/text/StringConcatenate.h M Source/WTF/wtf/text/StringView.cpp M Source/WTF/wtf/text/SymbolImpl.h M Source/WTF/wtf/text/UniquedStringImpl.h Log Message: ----------- Suppress virtual destructor and uncounted member variable warnings in WTF https://bugs.webkit.org/show_bug.cgi?id=274434 Reviewed by David Kilzer. Suppress webkit.NoUncountedMemberChecker and webkit.RefCntblBaseVirtualDtor in a few places. This PR moves inline functions out of line for classes with virtual destructor warning suppressions so that other checkers will continue to apply to their contents. * Source/WTF/wtf/Compiler.h: * Source/WTF/wtf/JSONValues.h: (WTF::JSONImpl::ObjectBase): Suppress the lack of virtual destructor warning. (WTF::JSONImpl::ArrayBase): Ditto. * Source/WTF/wtf/text/AtomStringImpl.cpp: * Source/WTF/wtf/text/AtomStringImpl.h: (WTF::AtomStringImpl): Ditto. (WTF::AtomStringImpl::lookUp): Moved out of line so that other checkers will continue to apply to function contents. (WTF::AtomStringImpl::add): Ditto. (WTF::AtomStringImpl::addCString): Ditto. (WTF::AtomStringImpl::addWithStringTableProvider): Ditto. * Source/WTF/wtf/text/StringConcatenate.h: (WTF::StringTypeAdapter): Suppress the uncounted member variable warning. * Source/WTF/wtf/text/StringView.cpp: (WTF::StringView::UnderlyingString): Ditto. * Source/WTF/wtf/text/SymbolImpl.h: (WTF::SymbolImpl::SymbolImpl): Suppress the lack of virtual destructor warning. (WTF::SymbolImpl::SymbolImpl): Moved out of line so that other checkers will continue to apply to function contents. (WTF::SymbolImpl::StaticSymbolImpl::StaticSymbolImpl): Ditto. * Source/WTF/wtf/text/UniquedStringImpl.h: (WTF::UniquedStringImpl): Suppress the lack of virtual destructor warning. (WTF::UniquedStringImpl::UniquedStringImpl): Moved out of line so that other checkers will continue to apply to function contents. Canonical link: https://commits.webkit.org/279061@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes